New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635405 link

Starred by 6 users
Status: Verified
Owner:
█ dhend...@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
ajha@chromium.org
ka...@chromium.org
█ kavvaru@chromium.org
sontis@chromium.org
█ shrawan@chromium.org
█ helenharris@chromium.org
pucchakayala@chromium.org
█ brajkumar@chromium.org
█ josa...@chromium.org
█ souvikghosh@google.com
kathrelk...@chromium.org
█ sha...@chromium.org
songsuk@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[SandyBridge boards Parrot, Lumpy, Butterfly] : Recovery is unsuccessful since 54.0.2822.0/8684.0.0 via USB.

Project Member Reported by mm00333...@techmahindra.com, Aug 8 2016 
Version: 54.0.2822.0/8684.0.0 dev-channel- Parrot
OS: Chrome

What steps will reproduce the problem?
1.Connect the USB with 54.0.2822.0/8684.0.0 dev.
2.Try to recover the build(Esc+reload+power) and observe.

Expected:Should be able to recover the build. 
Actual:Unable to recover the OS via USB, throbber keeps on revolving

Note:
1.Issue is seen only on Parrot device
2.Recovery is successful with the same version in Paine and Peach pit devices

This is a Regression issue as build recovery is successful with 54.0.2822.0/8684.0.0(Official Build) dev-channel Paine and Peach pit

Comment 1 by kavvaru@chromium.org, Aug 8 2016

Cc: kathrelk...@chromium.org songsuk@chromium.org pucchakayala@chromium.org
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Parrot using chrome version 54.0.2822.0/8684.0.0.
cced morning planner.

Comment 2 by kavvaru@chromium.org, Aug 8 2016 

seeing this issue on Butterfly device as well with the builds 54.0.2822.0/8684.0.0

Comment 3 by abod...@chromium.org, Aug 8 2016

Cc: ka...@chromium.org sontis@chromium.org
AU passed to M54(8685.0.0/54.0.2822.0) on parrot.

Comment 4 by son...@google.com, Aug 8 2016

Labels: -ReleaseBlock-Dev ReleaseBlock-Stable

Comment 5 by son...@google.com, Aug 8 2016 

Not able to install recovery image 8685.0.0.
Device continuously displaying "system recovery in progress".
Recovery logs are not present in USB stick.

Comment 6 by kalin@google.com, Aug 8 2016

Cc: josa...@chromium.org

Comment 7 by helenzhang@google.com, Aug 9 2016 

Unable to install Lumpy in ChromeOS M54-Dev 8685.0.0, 54.0.2822.0 using USB stick. Recovery started, but failed after verification with "unexpected error". 2 Lumpy installed. 

recovery log: https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/635405/

Comment 8 by bhthompson@chromium.org, Aug 9 2016

Cc: sha...@chromium.org
Owner: dhend...@chromium.org
+dhendrix, shawnn can one of you two take a closer look at why this might be breaking? This looks bad... like the firmware updater had a seg fault? 

...
Command: /tmp/install-mount-point/usr/sbin/chromeos-firmwareupdate --mode=recovery
Starting Google_Lumpy firmware updater v3 (recovery)...
 - Updater package: [Google_Lumpy.2.111.0 / 02WQA015]
 - Current system:  [RO:Google_Lumpy.2.111.0 , ACT:Google_Lumpy.2.111.0 / 02WQA015]
Warning: wpsw_cur is not availble, using wpsw_boot (1)
Segmentation fault
 - Write protection: Hardware: ON, Software: Main=off EC=off
Warning: wpsw_cur is not availble, using wpsw_boot (1)
mode_recovery: update RO+RW
 * invoke: flashrom -p host --fast-verify -w bios.bin
Warning: wpsw_cur is not availble, using wpsw_boot (1)
Segmentation fault
mode_recovery: update ec/RO+RW
 * invoke: flashrom -p ec --fast-verify -w ec.bin
 Execution failed (139): flashrom -p ec --fast-verify -w ec.bin
 Messages:


flashrom v0.9.4  : 915e741 : Jul 30 2016 02:22:27 UTC on Linux 3.8.11 (x86_64)flashrom v0.9.4  : 915e741 : Jul 30 2016 02:22:27 UTC on Linux 3.8.11 (x86_64)Segmentation fault
ERROR: Execution FAILED.
ERROR: Execution failed: ./updater3.sh (error code = 1)
Finished after 26 seconds.
Failed Command: /tmp/install-mount-point/usr/sbin/chromeos-firmwareupdate --mode=recovery - Exit Code 1
Firmware update failed (error code: 1).
Rolling back update due to failure installing required firmware.
Successfully updated GPT with all settings to rollback.
PostInstall Failed
...

Comment 9 by kalin@google.com, Aug 9 2016

Summary: [SandyBridge boards Parrot, Lumpy, Butterfly] : Recovery is unsuccessful since 54.0.2822.0/8684.0.0 via USB. (was: Regression : Recovery is unsuccessful with 54.0.2822.0/8684.0.0 via USB. )

Comment 10 by josa...@chromium.org, Aug 9 2016

Labels: -ReleaseBlock-Stable ReleaseBlock-Dev
Status: Assigned (was: Untriaged)

Comment 11 by dhend...@chromium.org, Aug 9 2016 

I've requested a Sandybridge Chromebook from chromestop to try and reproduce. There were some potentially disruptive changes checked in last month, so there could be something overlooked which affects these particular systems. (I would have expected the fallout to be much wider if they were at fault, though)

Comment 12 by dhend...@chromium.org, Aug 9 2016

Cc: souvikghosh@google.com
Looks like EC firmware read is failing because it is trying to probe for an LPC flash chip. The EC on Lumpy is an SMSC MEC1308 connected via the LPC bus, and acts like a bridge to a SPI flash chip. Here's are the last few lines of the verbose output I am seeing when trying to read the EC firmware (full log attached):

...
mec1308_probe_spi_flash(): entered

super i/o index = 0x002e
Found EC: MEC1310 (ID:0x04,Rev:0x02) on sio_port:0x2e.
mec1308_probe_spi_flash: mbx_idx: 0x0a00, mbx_data: 0x0a01
mec1308_exit_passthru_mode: result: 0xfe (failed to exit passthru mode)
enter_passthru_mode(): entering passthru mode, attempt 1 out of 3
enter_passthru_mode(): enter passthru mode return code: 0xaa
enter_passthru_mode(): start passthru mode return code: 0xaa
mec1308_probe_spi_flash(): successfully initialized mec1308
Probing for AMIC A25L05PT, 64 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L05PU, 64 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L10PT, 128 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L10PU, 128 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L20PT, 256 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L20PU, 256 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L40PT, 512 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L40PU, 512 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L80P, 1024 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L16PT, 2048 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L16PU, 2048 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L512, 64 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L010, 128 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L020, 256 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L040, 512 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L080, 1024 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L016, 2048 kB: id1 0xef, id2 0x4017
Probing for AMIC A25L032, 4096 kB: id1 0xef, id2 0x4017
Probing for AMIC A25LQ032, 4096 kB: id1 0xef, id2 0x4017
Probing for AMIC A49LF040A, 512 kB: Segmentation fault (core dumped)
lumpy_ec_read_fail.txt
5.6 KB View Download

Comment 13 by son...@google.com, Aug 9 2016 

Still able to reproduce this issue on build 8688.0.0_parrot

Comment 14 by dhend...@chromium.org, Aug 9 2016 

https://chromium-review.googlesource.com/#/c/358012 seems to be the culprit. We're looking into ways to fix it up, but if we can't find a good solution we'll revert the patch today.

Comment 15 by dhend...@chromium.org, Aug 10 2016

Labels: Merge-Request-54
Unfortunately coming up with a fix proved to be a bit trickier than we had hoped, and also the patch was pretty large so other patches will need to be reverted too:
https://chromium-review.googlesource.com/367501 Revert "Have all shutdown functions take a flashctx argument"
https://chromium-review.googlesource.com/367502 Revert "Fix for chip probing failing with multiple programmers"
https://chromium-review.googlesource.com/367503 Revert "cros_ec: Create global variable for private data"
https://chromium-review.googlesource.com/367504 Revert "Update all programmer init functions to register bus programmers ...

With those four patches reverted, I was able to build and read the EC firmware successfully on my Lumpy. We can re-introduce them in order once the "Update all programmer init functions to register bus programmers" patch has a proper fix.

Comment 16 by josa...@google.com, Aug 10 2016

Labels: -Merge-Request-54 Merge-Approved-54
Dave, could you merge these reverts to stabilize-8688.B? (This is the mini-branch I'm using for Dev release)
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 10 2016

Labels: merge-merged-stabilize-8688.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/55a6656b392f614025550084c7f830b7d604cb56

commit 55a6656b392f614025550084c7f830b7d604cb56
Author: David Hendricks <dhendrix@chromium.org>
Date: Wed Aug 10 02:10:51 2016

Revert "Have all shutdown functions take a flashctx argument"

This reverts commit 052210a7daabc365a65c67a5941d388a05fe0b96.

BUG= chromium:635405 

Change-Id: Iadafdf861e60baa757adda2bc965846bcaa36c82
Reviewed-on: https://chromium-review.googlesource.com/367435
Reviewed-by: David Hendricks <dhendrix@chromium.org>
Commit-Queue: David Hendricks <dhendrix@chromium.org>
Tested-by: David Hendricks <dhendrix@chromium.org>

[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/pcidev.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/cli_mfg.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/satamv.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/gfxnvidia.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/flash.h
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/cros_ec_lpc.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/linux_mtd.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/wpce775x.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/buspirate_spi.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/atahpt.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/nicintel_spi.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/hwaccess.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/nicintel.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/internal.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/serprog.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/dummyflasher.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/it85spi.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/programmer.h
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/linux_i2c.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/dediprog.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/raiden_debug_spi.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/satasii.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/nicrealtek.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/ene_lpc.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/nicnatsemi.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/mec1308.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/cros_ec_dev.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/cros_ec_i2c.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/nic3com.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/drkaiser.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/ogp_spi.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/flashrom.c
[modify] https://crrev.com/55a6656b392f614025550084c7f830b7d604cb56/linux_spi.c
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 10 2016

Labels: merge-merged-stabilize-8688.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/d853b6e71729ed9157695861b68f925c41fca5e9

commit d853b6e71729ed9157695861b68f925c41fca5e9
Author: David Hendricks <dhendrix@chromium.org>
Date: Wed Aug 10 02:10:53 2016

Revert "Fix for chip probing failing with multiple programmers"

This reverts commit af9627666e9f1f8f73c4e433f82b4bcc508a2624.

BUG= chromium:635405 

Change-Id: I0431338f95d18ff455c495f42ecabb5c43300ebf
Reviewed-on: https://chromium-review.googlesource.com/367436
Reviewed-by: David Hendricks <dhendrix@chromium.org>
Commit-Queue: David Hendricks <dhendrix@chromium.org>
Tested-by: David Hendricks <dhendrix@chromium.org>

[modify] https://crrev.com/d853b6e71729ed9157695861b68f925c41fca5e9/cli_mfg.c
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/e736d21daec93c5a2796708cbb49041669ab7f1a

commit e736d21daec93c5a2796708cbb49041669ab7f1a
Author: David Hendricks <dhendrix@chromium.org>
Date: Wed Aug 10 02:10:55 2016

Revert "Update all programmer init functions to register bus programmers into common list"

This reverts commit 63b92f99a9d43dd637bcce564cd372be3c81c5d8.

BUG= chromium:635405 

Change-Id: Ifbb0cf59dcfbd1ae9b71b070e9ce91b6150d2fbf
Reviewed-on: https://chromium-review.googlesource.com/367438
Reviewed-by: David Hendricks <dhendrix@chromium.org>
Commit-Queue: David Hendricks <dhendrix@chromium.org>
Tested-by: David Hendricks <dhendrix@chromium.org>

[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/cli_mfg.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/satamv.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/opaque.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/gfxnvidia.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/ft2232_spi.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/nicnatsemi.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/dediprog.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/flash.h
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/cros_ec_lpc.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/linux_mtd.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/wpce775x.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/buspirate_spi.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/atahpt.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/rayer_spi.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/it87spi.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/mcp6x_spi.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/spi.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/nicintel.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/it85spi.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/programmer.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/serprog.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/dummyflasher.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/internal.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/programmer.h
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/linux_i2c.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/ichspi.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/raiden_debug_spi.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/satasii.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/drkaiser.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/nicrealtek.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/ene_lpc.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/cros_ec.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/cli_classic.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/mec1308.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/cros_ec_dev.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/cros_ec_i2c.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/spi25.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/nic3com.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/bitbang_spi.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/ogp_spi.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/flashrom.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/nicintel_spi.c
[modify] https://crrev.com/e736d21daec93c5a2796708cbb49041669ab7f1a/linux_spi.c
Project Member

Comment 21 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/93784b496182e295ef33b22e33208de34f5950a5

commit 93784b496182e295ef33b22e33208de34f5950a5
Author: David Hendricks <dhendrix@chromium.org>
Date: Wed Aug 10 00:00:38 2016

Revert "Have all shutdown functions take a flashctx argument"

This reverts commit 052210a7daabc365a65c67a5941d388a05fe0b96.

BUG= chromium:635405 

Change-Id: If724c9772e2cf21d998d25576aa0d685b3480263
Reviewed-on: https://chromium-review.googlesource.com/367501
Commit-Ready: David Hendricks <dhendrix@chromium.org>
Tested-by: David Hendricks <dhendrix@chromium.org>
Reviewed-by: David Hendricks <dhendrix@chromium.org>

[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/pcidev.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/cli_mfg.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/satamv.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/gfxnvidia.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/flash.h
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/cros_ec_lpc.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/linux_mtd.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/wpce775x.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/buspirate_spi.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/atahpt.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/nicintel_spi.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/hwaccess.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/nicintel.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/internal.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/serprog.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/dummyflasher.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/it85spi.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/programmer.h
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/linux_i2c.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/dediprog.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/raiden_debug_spi.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/satasii.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/nicrealtek.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/ene_lpc.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/nicnatsemi.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/mec1308.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/cros_ec_dev.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/cros_ec_i2c.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/nic3com.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/drkaiser.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/ogp_spi.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/flashrom.c
[modify] https://crrev.com/93784b496182e295ef33b22e33208de34f5950a5/linux_spi.c
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/6fd7b675ea3ffda0b7e34c2b336f77aad8749ecf

commit 6fd7b675ea3ffda0b7e34c2b336f77aad8749ecf
Author: David Hendricks <dhendrix@chromium.org>
Date: Wed Aug 10 00:00:46 2016

Revert "Fix for chip probing failing with multiple programmers"

This reverts commit af9627666e9f1f8f73c4e433f82b4bcc508a2624.

BUG= chromium:635405 

Change-Id: I7752d4438e4a9470268fefde101568f1e72fa554
Reviewed-on: https://chromium-review.googlesource.com/367502
Commit-Ready: David Hendricks <dhendrix@chromium.org>
Tested-by: David Hendricks <dhendrix@chromium.org>
Reviewed-by: David Hendricks <dhendrix@chromium.org>

[modify] https://crrev.com/6fd7b675ea3ffda0b7e34c2b336f77aad8749ecf/cli_mfg.c
Project Member

Comment 24 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/ac1d25c100bcd37075ec4b674a16f54edcd31d94

commit ac1d25c100bcd37075ec4b674a16f54edcd31d94
Author: David Hendricks <dhendrix@chromium.org>
Date: Wed Aug 10 00:00:58 2016

Revert "Update all programmer init functions to register bus programmers into common list"

This reverts commit 63b92f99a9d43dd637bcce564cd372be3c81c5d8.

BUG= chromium:635405 

Change-Id: I94ae18b547d2aedd74fc7103a38dcbfd2f57be66
Reviewed-on: https://chromium-review.googlesource.com/367504
Commit-Ready: David Hendricks <dhendrix@chromium.org>
Tested-by: David Hendricks <dhendrix@chromium.org>
Reviewed-by: David Hendricks <dhendrix@chromium.org>

[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/cli_mfg.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/satamv.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/opaque.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/gfxnvidia.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/ft2232_spi.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/nicnatsemi.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/dediprog.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/flash.h
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/cros_ec_lpc.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/linux_mtd.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/wpce775x.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/buspirate_spi.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/atahpt.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/rayer_spi.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/it87spi.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/mcp6x_spi.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/spi.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/nicintel.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/it85spi.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/programmer.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/serprog.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/dummyflasher.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/internal.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/programmer.h
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/linux_i2c.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/ichspi.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/raiden_debug_spi.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/satasii.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/drkaiser.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/nicrealtek.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/ene_lpc.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/cros_ec.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/cli_classic.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/mec1308.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/cros_ec_dev.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/cros_ec_i2c.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/spi25.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/nic3com.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/bitbang_spi.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/ogp_spi.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/flashrom.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/nicintel_spi.c
[modify] https://crrev.com/ac1d25c100bcd37075ec4b674a16f54edcd31d94/linux_spi.c

Comment 25 by dhend...@chromium.org, Aug 10 2016

Status: Fixed (was: Assigned)
Revert patches landed in ToT and stabilize-8688.B, marking as fixed.

Comment 26 by son...@google.com, Aug 11 2016

Status: Verified (was: Fixed)
Verified on Lumpy, parrot and Butterfly with build 8696.0.0
Recovery is working fine.

Comment 27 by josa...@chromium.org, Aug 11 2016 

Can you also confirm this is working on 8688.2.0?

Comment 28 by helenzhang@google.com, Aug 11 2016 

Lumpy/parrot work fine in 8688.2.0.
Project Member

Comment 29 by sheriffbot@chromium.org, Aug 13 2016 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 30 by bugdroid1@chromium.org, Aug 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/586968a37e7078c713b6143f0c6e07ae0eeee755

commit 586968a37e7078c713b6143f0c6e07ae0eeee755
Author: Souvik Ghosh <souvikghosh@google.com>
Date: Fri Aug 12 00:56:24 2016

Patch up reverted merges and create global cros_ec variable

This patch essentially reapplies CL:357911, which was reverted
along with 3 other patches, so that future patches can be rebased
on top of this. The reverted patches were intended to combine the
global spi/par/opaque programmer variables into a union as a field
in a new struct, registered_programmer (this is implemented in
upstream). However, because of some complications with certain
cases involving multiple programmers, we are keeping the globals.

BUG= chromium:635405 
BRANCH=none
TEST=successfully reads on Lumpy, Jaq, and Link

Change-Id: Ife8f24d852ba0e6dba6051d05837789ff8600714
Signed-off-by: Souvik Ghosh <souvikghosh@google.com>
Reviewed-on: https://chromium-review.googlesource.com/368480
Reviewed-by: David Hendricks <dhendrix@chromium.org>

[modify] https://crrev.com/586968a37e7078c713b6143f0c6e07ae0eeee755/cros_ec.c
[modify] https://crrev.com/586968a37e7078c713b6143f0c6e07ae0eeee755/cros_ec_dev.c
[modify] https://crrev.com/586968a37e7078c713b6143f0c6e07ae0eeee755/cros_ec.h
[modify] https://crrev.com/586968a37e7078c713b6143f0c6e07ae0eeee755/cros_ec_lpc.c
[modify] https://crrev.com/586968a37e7078c713b6143f0c6e07ae0eeee755/cros_ec_i2c.c
Project Member

Comment 31 by sheriffbot@chromium.org, Aug 16 2016 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 32 by kathrelk...@chromium.org, Aug 16 2016

Labels: -Merge-Approved-54 Merge-Merged
►

Sign in to add a comment