New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635386 link

Starred by 2 users
Status: Fixed
Owner:
█ dglazkov@chromium.org
OOO until NaN
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

WebRange should be a simple start+end pair of numbers

Project Member Reported by dglazkov@chromium.org, Aug 8 2016 
Currently, the WebRange actually wraps the Range object, which is a fairly complex beast. None of the uses of the embedder API actually need to see this complexity, so it would be great if we could just have a simple WebRange struct holding two numbers: start of the range and the end of the range.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f8060f3c58fe047bc3d9de90752cf3735f6beac

commit 8f8060f3c58fe047bc3d9de90752cf3735f6beac
Author: dglazkov <dglazkov@chromium.org>
Date: Wed Aug 10 18:47:43 2016

Convert WebRange to be a simple pair of numbers.

Instead of wrapping and carrying a fairly complex Range object, just use a pair of numbers to convey this information outside of the renderer. The embedders don't
need anything else.

R=avi,esprehn
BUG= 635386 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2199523002
Cr-Commit-Position: refs/heads/master@{#411104}

[modify] https://crrev.com/8f8060f3c58fe047bc3d9de90752cf3735f6beac/components/printing/test/print_web_view_helper_browsertest.cc
[modify] https://crrev.com/8f8060f3c58fe047bc3d9de90752cf3735f6beac/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/8f8060f3c58fe047bc3d9de90752cf3735f6beac/content/renderer/render_view_impl.cc
[modify] https://crrev.com/8f8060f3c58fe047bc3d9de90752cf3735f6beac/content/renderer/render_widget.cc
[modify] https://crrev.com/8f8060f3c58fe047bc3d9de90752cf3735f6beac/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/8f8060f3c58fe047bc3d9de90752cf3735f6beac/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/8f8060f3c58fe047bc3d9de90752cf3735f6beac/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/8f8060f3c58fe047bc3d9de90752cf3735f6beac/third_party/WebKit/Source/web/WebRange.cpp
[modify] https://crrev.com/8f8060f3c58fe047bc3d9de90752cf3735f6beac/third_party/WebKit/Source/web/WebSurroundingText.cpp
[modify] https://crrev.com/8f8060f3c58fe047bc3d9de90752cf3735f6beac/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/8f8060f3c58fe047bc3d9de90752cf3735f6beac/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/8f8060f3c58fe047bc3d9de90752cf3735f6beac/third_party/WebKit/public/web/WebLocalFrame.h
[modify] https://crrev.com/8f8060f3c58fe047bc3d9de90752cf3735f6beac/third_party/WebKit/public/web/WebRange.h
[modify] https://crrev.com/8f8060f3c58fe047bc3d9de90752cf3735f6beac/third_party/WebKit/public/web/WebSurroundingText.h

Comment 2 by dglazkov@chromium.org, Aug 12 2016

Status: Fixed (was: Started)
►

Sign in to add a comment