New issue
Advanced search Search tips

Issue 635381 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Chromevox find command is broken

Reported by nimerjaber1@gmail.com, Aug 8 2016

Issue description

Mode: force_next
Version: 54.0.2822.0
Reproduction Steps: 
1. Enable Chromevox Next
2. Navigate to a web page.
3. Perform a search for a text string that is present on the page with CVox+/
Expected: A user is brought to that text or link.
Actual: The search appears to not work. Sometimes, I am unable to even type in the box. There appears to be buttons to launch Chromevox options, however there does not seem to be a way to navigate to that control. CVox+right and down arrows does nothing, tab and shift + tab does nothing... even when I am able to type in the search box, typing and pressing enter does not navigate to the text that I searched for.
 
Labels: Phase3
Owner: dtseng@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcf3ed28c3ad8a341f3319e425474016ac9904d5

commit dcf3ed28c3ad8a341f3319e425474016ac9904d5
Author: dtseng <dtseng@chromium.org>
Date: Tue Aug 16 15:15:23 2016

Support output for Chrome's native find in ChromeVox.

The i-search impl currently suffers from two major problems:
- performance: asking each node for its name causes a context change from js to native and back; on a large site it was taking on the order of minutes to hear the next search result
- walking the automation tree while the find dialog is up often times causes ndoes to be detached

This cl makes it so:
- ctrl+f search read out properly and sync ChromeVox's cursor
- actual system focus remains on the find dialog
- the user would need to press escape to continue navigation from the search hit

BUG= 635381 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2238613002
Cr-Commit-Position: refs/heads/master@{#412239}

[modify] https://crrev.com/dcf3ed28c3ad8a341f3319e425474016ac9904d5/chrome/browser/resources/chromeos/chromevox/BUILD.gn
[modify] https://crrev.com/dcf3ed28c3ad8a341f3319e425474016ac9904d5/chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js
[modify] https://crrev.com/dcf3ed28c3ad8a341f3319e425474016ac9904d5/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
[add] https://crrev.com/dcf3ed28c3ad8a341f3319e425474016ac9904d5/chrome/browser/resources/chromeos/chromevox/cvox2/background/find_handler.js
[modify] https://crrev.com/dcf3ed28c3ad8a341f3319e425474016ac9904d5/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/dcf3ed28c3ad8a341f3319e425474016ac9904d5/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/dcf3ed28c3ad8a341f3319e425474016ac9904d5/chrome/renderer/extensions/automation_internal_custom_bindings.h
[modify] https://crrev.com/dcf3ed28c3ad8a341f3319e425474016ac9904d5/chrome/renderer/resources/extensions/automation/automation_node.js
[modify] https://crrev.com/dcf3ed28c3ad8a341f3319e425474016ac9904d5/third_party/WebKit/Source/web/TextFinder.cpp

Comment 3 by chaok@google.com, Aug 22 2016

Cvox find WAI in: Version 54.0.2831.0 canary (64-bit)

Comment 4 by chaok@google.com, Oct 2 2016

Status: Verified (was: Assigned)

Sign in to add a comment