New issue
Advanced search Search tips

Issue 635347 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Move expensive calls in ShortcutHelper off of IO thread

Project Member Reported by pkotw...@chromium.org, Aug 7 2016

Issue description

Move expensive calls in ShortcutHelper off of IO thread
 
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a

commit c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a
Author: pkotwicz <pkotwicz@chromium.org>
Date: Fri Aug 12 19:56:44 2016

Run ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap() on Worker thread instead of IO thread

This CL runs ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap() on a
worker thread instead of the IO thread. According to
https://www.chromium.org/developers/design-documents/threading expensive tasks
should not be done on the IO thread. This CL also changes
ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap() so that only the
expensive parts are run on the worker thread instead of the entire process
started by ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap() running on
the worker thread.

BUG= 635347 

Review-Url: https://codereview.chromium.org/2228273002
Cr-Commit-Position: refs/heads/master@{#411743}

[modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/android/javatests/src/org/chromium/chrome/browser/browsing_data/BrowsingDataRemoverIntegrationTest.java
[modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
[modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java
[modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java
[modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
[modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/browser/android/shortcut_helper.h
[modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/browser/android/webapk/webapk_installer.h
[modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
[modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/testing/android/junit/java/src/org/chromium/testing/local/BackgroundShadowAsyncTask.java

Status: Fixed (was: Started)

Sign in to add a comment