Move expensive calls in ShortcutHelper off of IO thread
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5774087e1934b4d45ebca21786c461ec5a467410 commit 5774087e1934b4d45ebca21786c461ec5a467410 Author: pkotwicz <pkotwicz@chromium.org> Date: Wed Aug 10 17:36:40 2016 Calls ShortcutHelper::FinalizeLauncherIcon() on worker thread instead of on IO thread BUG= 635347 Review-Url: https://codereview.chromium.org/2218413002 Cr-Commit-Position: refs/heads/master@{#411068} [modify] https://crrev.com/5774087e1934b4d45ebca21786c461ec5a467410/chrome/browser/android/shortcut_helper.cc [modify] https://crrev.com/5774087e1934b4d45ebca21786c461ec5a467410/chrome/browser/android/shortcut_helper.h [modify] https://crrev.com/5774087e1934b4d45ebca21786c461ec5a467410/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc [modify] https://crrev.com/5774087e1934b4d45ebca21786c461ec5a467410/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h [modify] https://crrev.com/5774087e1934b4d45ebca21786c461ec5a467410/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc [modify] https://crrev.com/5774087e1934b4d45ebca21786c461ec5a467410/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a commit c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a Author: pkotwicz <pkotwicz@chromium.org> Date: Fri Aug 12 19:56:44 2016 Run ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap() on Worker thread instead of IO thread This CL runs ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap() on a worker thread instead of the IO thread. According to https://www.chromium.org/developers/design-documents/threading expensive tasks should not be done on the IO thread. This CL also changes ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap() so that only the expensive parts are run on the worker thread instead of the entire process started by ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap() running on the worker thread. BUG= 635347 Review-Url: https://codereview.chromium.org/2228273002 Cr-Commit-Position: refs/heads/master@{#411743} [modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java [modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/android/javatests/src/org/chromium/chrome/browser/browsing_data/BrowsingDataRemoverIntegrationTest.java [modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java [modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java [modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java [modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc [modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/browser/android/shortcut_helper.cc [modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/browser/android/shortcut_helper.h [modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/browser/android/webapk/webapk_installer.cc [modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/browser/android/webapk/webapk_installer.h [modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc [modify] https://crrev.com/c67e6ac6fb0cc0b0ba6582ea1a9e8e62caf9748a/testing/android/junit/java/src/org/chromium/testing/local/BackgroundShadowAsyncTask.java
Comment 1 by bugdroid1@chromium.org
, Aug 10 2016