GN: silence warning when generating Assets.car |
||
Issue descriptionactool prints useless warning when compiling Assets.car, they should be silenced so that real warning are not lost. Currently, we see this: [6841/68082] COMPILE_XCASSETS Chrome.app/Assets.car /* com.apple.actool.compilation-results */ /Users/sdefresne/Developer/chromium/src/out/Official-iphoneos/Chrome.app/Assets.car In addition, when the asset catalog is malformed (missing files, ...) actool only prints warning and the compilation succeed. It should instead fail so that developer fix the issue before landing their CL.
,
Aug 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b150b0a5a28f95f651767f901819390fc065676 commit 5b150b0a5a28f95f651767f901819390fc065676 Author: sdefresne <sdefresne@chromium.org> Date: Tue Aug 09 21:22:50 2016 Make compile_xcassets.py less verbose. Parse output of actool and discard uninteresting messages and fail on unexpected warning messages (as actool termines with a success error code even if some resources are missing). BUG= 635306 Review-Url: https://codereview.chromium.org/2224763002 Cr-Commit-Position: refs/heads/master@{#410824} [modify] https://crrev.com/5b150b0a5a28f95f651767f901819390fc065676/build/toolchain/mac/compile_xcassets.py
,
Aug 9 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by sdefresne@chromium.org
, Aug 7 2016