Re-organize RPCs from master/shard AFE |
|||
Issue descriptionThe master and shard RPCs now are mixing together, which leads to: 1. There may be imperceptible RPCs errors like 'should be executed from master but now executed from shard directly'. 2. Developers are hard to detect different kinds of RPCs, even harder to call these RPCs properly. This bug is to track the fix of this problem.
,
Aug 26 2016
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/543835d098916b1615e8fb3b12c4e2f6403a2ea4 commit 543835d098916b1615e8fb3b12c4e2f6403a2ea4 Author: xixuan <xixuan@google.com> Date: Mon Aug 22 21:39:27 2016 Autotest: Add an Rpc Validator to limit RPCs that can only be called by master. Some RPCs cannot be called by caller except master AFE, or it will lead to db inconsistency between shard and master. This CL fixes this problem by adding an RPC validator to filter such calls from RPC handling side. The validor will refuse any calls whose caller is not master AFE but the target calling method is RPCs in shard. BUG= chromium:635288 TEST=Testing with a cbf master and a cbf shard: shard works, jobs can be picked up, scheduled and worked. Check master/shard AFEs, can't see any missing contents. Change-Id: Iad52e6173a1f785e4d48ca5287a5c1dd2fce17ab Reviewed-on: https://chromium-review.googlesource.com/374139 Commit-Ready: Xixuan Wu <xixuan@chromium.org> Tested-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/543835d098916b1615e8fb3b12c4e2f6403a2ea4/frontend/afe/rpc_handler.py
,
Jun 20 2017
I believe someone else already works part of it and have their own bugs. So mark this one as wontfix. |
|||
►
Sign in to add a comment |
|||
Comment 1 by crackhou...@gmail.com
, Aug 7 2016