New issue
Advanced search Search tips

Issue 635207 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

"org.chromium.content.browser.VibrationManagerImplTest#testVibrate" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 6 2016

Issue description

"org.chromium.content.browser.VibrationManagerImplTest#testVibrate" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTAsSBUZsYWtlIkFvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLlZpYnJhdGlvbk1hbmFnZXJJbXBsVGVzdCN0ZXN0VmlicmF0ZQw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Aug 8 2016

Detected 3 new flakes for test/step "org.chromium.content.browser.VibrationManagerImplTest#testVibrate". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTAsSBUZsYWtlIkFvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLlZpYnJhdGlvbk1hbmFnZXJJbXBsVGVzdCN0ZXN0VmlicmF0ZQw. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 2 by chromium...@appspot.gserviceaccount.com, Aug 8 2016

Detected 3 new flakes for test/step "org.chromium.content.browser.VibrationManagerImplTest#testVibrate". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTAsSBUZsYWtlIkFvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLlZpYnJhdGlvbk1hbmFnZXJJbXBsVGVzdCN0ZXN0VmlicmF0ZQw. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 3 by chromium...@appspot.gserviceaccount.com, Aug 9 2016

Detected 3 new flakes for test/step "org.chromium.content.browser.VibrationManagerImplTest#testVibrate". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTAsSBUZsYWtlIkFvcmcuY2hyb21pdW0uY29udGVudC5icm93c2VyLlZpYnJhdGlvbk1hbmFnZXJJbXBsVGVzdCN0ZXN0VmlicmF0ZQw. This message was posted automatically by the chromium-try-flakes app.
The failures are all on linux_android_rel_ng and look like this:

org.chromium.content.browser.VibrationManagerImplTest#testVibrate (run #1):
junit.framework.AssertionFailedError: Criteria not met in allotted time.
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:112)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:133)
	at org.chromium.content.browser.VibrationManagerImplTest.testVibrate(VibrationManagerImplTest.java:83)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:233)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Cc: tedc...@chromium.org leon....@intel.com
Owner: dcheng@chromium.org
Status: Assigned (was: Untriaged)
The first failure I see was on try run at 2016-07-29 13:57:04 UTC but unfortunately the logs for that run are gone.

That's 35 minutes after https://codereview.chromium.org/2191533003 landed, which touches modules/vibration and it seems plausible that the failure could have something to do with timers gone wrong. dcheng@, can you PTAL and if you don't think it's your fault hand over to tedchoc@ or leon.han@ (in CC)?
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c7e92b65a7f6dc968c1600a76049e209b74f7f6

commit 4c7e92b65a7f6dc968c1600a76049e209b74f7f6
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Tue Aug 09 10:03:28 2016

Disable VibrationManagerImplTest#testVibrate (flaky)

It has been flaky since July 29.

BUG= 635207 
TBR=dcheng@chromium.org

Review URL: https://codereview.chromium.org/2222333002 .

Cr-Commit-Position: refs/heads/master@{#410626}

[modify] https://crrev.com/4c7e92b65a7f6dc968c1600a76049e209b74f7f6/content/public/android/javatests/src/org/chromium/content/browser/VibrationManagerImplTest.java

Components: Tests>Disabled
Labels: -Sheriff-Chromium
Cc: dcheng@chromium.org
Components: Blink>Vibration
Owner: mvanouwe...@chromium.org
My change is a no-op. Assigning to a modules/vibration owner.
Labels: -Pri-1 Pri-3
Cc: mvanouwe...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Cc: -mvanouwe...@chromium.org

Comment 14 by leon....@intel.com, May 26 2017

Status: WontFix (was: Available)
70adfd46aefb86021a640567bdc07d6b6c73a066 has replaced VibrationManagerImplTest.java with other tests.
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment