New issue
Advanced search Search tips

Issue 635195 link

Starred by 3 users
Status: Assigned
Owner:
thomasanderson@chromium.org
Cc:
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Linux: Creating a new window by dragging a tab out animates

Project Member Reported by thomasanderson@chromium.org, Aug 5 2016 
Some Linux window managers animate windows in when opening them.  This means that when a user drags a tab out of a window, they have to wait for the animation to finish before being able to move the window around.

IMO the animation is slow and just gets in the way of what the user actually wants to do.

Comment 1 by thomasanderson@chromium.org, Oct 11 2016 

 Issue 341514  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbb8975f1693f4fb33d54f62bbef19a70a4bc724

commit fbb8975f1693f4fb33d54f62bbef19a70a4bc724
Author: thomasanderson <thomasanderson@google.com>
Date: Wed Oct 12 23:47:31 2016

Linux Aura: Make tab dragging great again

This CL uses _NET_WM_MOVERESIZE to handle tab dragging for managed windows on
select window managers.

This fixes various issues I've seen with tab dragging including:
* Window movement is no longer constrained by screen bounds
* Windows animating in during tab dragging is minimized
* Tab dragging is improved on tiling WMs
* Better integration with desktop environment (you can now drag to the top of
  the screen to maximize if the DE supports it, or drag left/right between
  workspaces)

BUG=416119,617806,635195
R=erg@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2410773002
Cr-Commit-Position: refs/heads/master@{#424909}

[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/base/x/x11_util.cc
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/base/x/x11_util.h
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/views/BUILD.gn
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
[add] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/views/widget/desktop_aura/x11_desktop_window_move_client_managed.cc
[add] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/views/widget/desktop_aura/x11_desktop_window_move_client_managed.h
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/views/widget/desktop_aura/x11_window_event_filter.cc
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/views/widget/desktop_aura/x11_window_event_filter.h
[modify] https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724/ui/wm/public/window_move_client.h
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3

commit ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3
Author: thomasanderson <thomasanderson@chromium.org>
Date: Tue Nov 01 20:31:03 2016

Revert of Linux Aura: Make tab dragging great again (patchset #4 id:60001 of https://codereview.chromium.org/2410773002/ )

Reason for revert:
Suspecting this is causing 661248, so conservatively reverting.

Original issue's description:
> Linux Aura: Make tab dragging great again
>
> This CL uses _NET_WM_MOVERESIZE to handle tab dragging for managed windows on
> select window managers.
>
> This fixes various issues I've seen with tab dragging including:
> * Window movement is no longer constrained by screen bounds
> * Windows animating in during tab dragging is minimized
> * Tab dragging is improved on tiling WMs
> * Better integration with desktop environment (you can now drag to the top of
>   the screen to maximize if the DE supports it, or drag left/right between
>   workspaces)
>
> BUG=416119,617806,635195
> R=erg@chromium.org,sky@chromium.org
>
> Committed: https://crrev.com/fbb8975f1693f4fb33d54f62bbef19a70a4bc724
> Cr-Commit-Position: refs/heads/master@{#424909}

TBR=erg@chromium.org,sky@chromium.org,derat@chromium.org,thomasanderson@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=416119,617806,635195

BUG= 661248 

Review-Url: https://codereview.chromium.org/2467053002
Cr-Commit-Position: refs/heads/master@{#429093}

[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/base/x/x11_util.cc
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/base/x/x11_util.h
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/views/BUILD.gn
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
[delete] https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d/ui/views/widget/desktop_aura/x11_desktop_window_move_client_managed.cc
[delete] https://crrev.com/4025c2cba57945b8b51ef021e2915906f3c71b0d/ui/views/widget/desktop_aura/x11_desktop_window_move_client_managed.h
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/views/widget/desktop_aura/x11_window_event_filter.cc
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/views/widget/desktop_aura/x11_window_event_filter.h
[modify] https://crrev.com/ef7d2678befe4a66cb1e2293f12b7f8c9eac2fa3/ui/wm/public/window_move_client.h

Comment 4 by lafo...@chromium.org, Jan 2 2017

Components: -UI>OSIntegration Internals>PlatformIntegration
Deprecating UI>OSIntegration in favor of the more generic Internals>PlatformIntegration

Comment 5 by e...@chromium.org, Mar 9 2018

Cc: -e...@chromium.org
Un-cc-ing me from all bugs on my final day.

Comment 6 by jmukthavaram@chromium.org, Nov 27

Labels: Hotlist-DesktopUIChecked
***UI Mass Triage ***

If there is no pending work, please feel free to close the issue.
►

Sign in to add a comment