New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635178 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 630357
issue 635166



Sign in to add a comment

Harmony - dialog close button

Project Member Reported by est...@chromium.org, Aug 5 2016

Issue description

The close button needs to be updated to a more MD appearance, probably just copying the [x] button in the find in page bar (or perhaps a bigger version of it?)
 

Comment 1 by bettes@chromium.org, Aug 10 2016

I need to understand what assets are currently being used because I think an asset update is needed here. In the current UX directory, there is find_close_disabled / pressed / close. Is this what's being used in Canary? 

https://drive.google.com/a/google.com/file/d/0B6x6iYCtKinEaWRRLUJ3bjNXTHM/view?usp=sharing
https://drive.google.com/a/google.com/file/d/0B6x6iYCtKinEbXdTRFA0SFVvdlU/view?usp=sharing
https://drive.google.com/a/google.com/file/d/0B6x6iYCtKinEOHB2OVlxckVuaDg/view?usp=sharing

Attached is a 1-to-1 comparison of harmony and the current MD close-x at 1x. Harmony has a lighter imprint and is the preferred, however both are cut at the same size: 16px. 

Email me with your insights before implementation. 

Screen Shot 2016-08-10 at 12.54.11 PM.png
6.1 KB View Download

Comment 2 by est...@chromium.org, Aug 10 2016

Wouldn't it be nice if there were just one [x] used everywhere? We actually have many different [x]s, but the most common is this one (2x dsf)

For MD in places like the FIP bar, it would be harder to attach because it's a .icon file and I don't know where the source svg is any more, although it looks like you already found it.
close_dialog.png
170 bytes View Download

Comment 3 by est...@chromium.org, Aug 23 2016

Owner: bettes@chromium.org
Status: Assigned (was: Available)
Ping on this. Can we have new SVGs or is the FIP [x] good to reuse?
I'm just going to reuse the find in page x for now.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6047258bfb18b2fa84bcb1be85243bd48f3ed71b

commit 6047258bfb18b2fa84bcb1be85243bd48f3ed71b
Author: estade <estade@chromium.org>
Date: Wed Sep 07 17:29:19 2016

Update dialog close buttons to use vector icons and ripples.

BUG= 635178 

Review-Url: https://codereview.chromium.org/2305933002
Cr-Commit-Position: refs/heads/master@{#416979}

[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc
[delete] https://crrev.com/d3f58bbf12466f909c06171c69ea227658a9044e/chrome/browser/ui/views/bar_control_button.h
[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/chrome/browser/ui/views/download/download_item_view_md.cc
[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/chrome/browser/ui/views/download/download_item_view_md.h
[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/chrome/browser/ui/views/download/download_shelf_view.cc
[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/chrome/browser/ui/views/download/download_shelf_view.h
[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/chrome/browser/ui/views/find_bar_view.h
[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/chrome/browser/ui/views/infobars/infobar_view.h
[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/chrome/browser/ui/views/toolbar/reload_button.cc
[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/ui/views/BUILD.gn
[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/ui/views/bubble/bubble_dialog_delegate_unittest.cc
[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/ui/views/bubble/bubble_frame_view.cc
[modify] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/ui/views/bubble/bubble_frame_view.h
[rename] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/ui/views/controls/button/vector_icon_button.cc
[add] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/ui/views/controls/button/vector_icon_button.h
[add] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/ui/views/controls/button/vector_icon_button_delegate.cc
[add] https://crrev.com/6047258bfb18b2fa84bcb1be85243bd48f3ed71b/ui/views/controls/button/vector_icon_button_delegate.h

Comment 6 by bettes@chromium.org, Sep 19 2016

Labels: Proj-MaterialDesign-NativeUI

Comment 7 Deleted

Comment 8 by bettes@chromium.org, Sep 23 2016

Sorry for the delay here. Let's re-use the "find_close.png" asset (find in page) from core ui for all platforms. 

https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)#%2FSPEC-secondary-UI-03c-dialog-specs.png


Screen Shot 2016-09-23 at 4.36.20 PM.png
66.5 KB View Download

Comment 9 by est...@chromium.org, Sep 26 2016

Status: Fixed (was: Assigned)

Sign in to add a comment