New issue
Advanced search Search tips

Issue 635170 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 630357
issue 635166



Sign in to add a comment

Harmony - stroke and shadow for dialogs

Project Member Reported by est...@chromium.org, Aug 5 2016

Issue description

The frame of the dialog should be drawn programatically according to the new specs for stroke and shadow (to be provided by bettes@). bsep has already started looking at this I believe, and in fact there may already be a bug filed for it.

Note that shadows should (tm) be easy to implement from designers' specs, assuming you use CreateShadowDrawLooperCorrectBlur() and not CreateShadowDrawLooper()
 

Comment 1 by bettes@chromium.org, Aug 10 2016

Dialog stroke and shadow specs:

https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)#%2FSPEC-secondary-UI-04c-dialog-specs.png
SPEC-secondary-UI-04c-dialog-specs.png
149 KB View Download

Comment 2 by est...@chromium.org, Sep 15 2016

Owner: est...@chromium.org
nabbing this.

Alan, a couple questions about the spec: you frequently use px, e.g. for shadow blur values and corner radius. Does this really mean px or is it dp aka dip aka pt?

Question 2: for the shadow blur values you have 4 values measured in pixels. I assume these are x offset, y offset, and blur, but I don't know what the 4th one is.

Question 3: just to confirm, we'll never use arrows, right?

Comment 3 by bsep@chromium.org, Sep 16 2016

I was working on  bug 624526 , which might have some useful context. Since we're removing arrows from bubbles that'll be irrelevant once this is implemented.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bd5f0cb97cd94f0bf6552f8f22d40c22d975b5f

commit 0bd5f0cb97cd94f0bf6552f8f22d40c22d975b5f
Author: estade <estade@chromium.org>
Date: Fri Sep 16 17:35:29 2016

Implement Harmony spec for dialog/bubble border aesthetics.

Uses drawing commands rather than raster assets.

This CL tries to retain/reuse the same positioning logic that already exists, but I didn't attempt to correct any bugs in positioning that might be introduced. That's up next.

BUG= 635170 

Review-Url: https://codereview.chromium.org/2343913003
Cr-Commit-Position: refs/heads/master@{#419203}

[modify] https://crrev.com/0bd5f0cb97cd94f0bf6552f8f22d40c22d975b5f/ui/views/bubble/bubble_border.cc
[modify] https://crrev.com/0bd5f0cb97cd94f0bf6552f8f22d40c22d975b5f/ui/views/bubble/bubble_border.h

Comment 5 by est...@chromium.org, Sep 16 2016

I'm not sure the date/release we'll switch away from arrows, but I would probably not prioritize working on that bug if you have other stuff that's equally or more important since it will probably be within the next two milestones.

Comment 6 by bettes@chromium.org, Sep 16 2016

1. Px is intended for non-scalable items like strokes but not for type and corner radii. Updates to the spec are needed
2. the 4th variable is "spread". I'm just using CSS terms here - that may not apply to our implementation
3. no arrows

Comment 7 by est...@chromium.org, Oct 28 2016

Status: Fixed (was: Assigned)
More or less done. Any further tweaks can be tracked in more specific bugs.

Sign in to add a comment