New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635169 link

Starred by 2 users
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: Aug 2016
Cc:
█ e...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Linux: (Implementation) Stop tracking _NET_ACTIVE_WINDOW

Project Member Reported by thomasanderson@chromium.org, Aug 5 2016 
X11DesktopHandler uses _NET_ACTIVE_WINDOW to track which window has focus.  We should not be tracking this property because we already know if a window is active based on FocusIn/FocusOut events.

Removing _NET_ACTIVE_WINDOW will:
1. Eliminate a round trip to get the value of _NET_ACTIVE_WINDOW each time it changes.
2. Track focus better for WMs that don't support _NET_ACTIVE_WINDOW.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b6aeffa075816129e32e57412b1c89ba619df10

commit 3b6aeffa075816129e32e57412b1c89ba619df10
Author: thomasanderson <thomasanderson@google.com>
Date: Fri Aug 26 21:19:52 2016

* Remove all tracking of _NET_ACTIVE_WINDOW
* Remove timestamp tracking from X11DesktopHandler
* Track focus state in DWTHX11. Inspired by gtk/docs/focus_tracking.txt
  Hopefully this will fix most Linux-aura focus related bugs

BUG= 635169 , 635177 

Review-Url: https://codereview.chromium.org/2165083002
Cr-Commit-Position: refs/heads/master@{#414807}

[modify] https://crrev.com/3b6aeffa075816129e32e57412b1c89ba619df10/chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc
[modify] https://crrev.com/3b6aeffa075816129e32e57412b1c89ba619df10/chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc
[modify] https://crrev.com/3b6aeffa075816129e32e57412b1c89ba619df10/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/3b6aeffa075816129e32e57412b1c89ba619df10/ui/events/devices/x11/touch_factory_x11.cc
[modify] https://crrev.com/3b6aeffa075816129e32e57412b1c89ba619df10/ui/events/platform/x11/x11_event_source.cc
[modify] https://crrev.com/3b6aeffa075816129e32e57412b1c89ba619df10/ui/events/platform/x11/x11_event_source.h
[modify] https://crrev.com/3b6aeffa075816129e32e57412b1c89ba619df10/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/3b6aeffa075816129e32e57412b1c89ba619df10/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
[modify] https://crrev.com/3b6aeffa075816129e32e57412b1c89ba619df10/ui/views/widget/desktop_aura/desktop_window_tree_host_x11_interactive_uitest.cc
[modify] https://crrev.com/3b6aeffa075816129e32e57412b1c89ba619df10/ui/views/widget/desktop_aura/x11_desktop_handler.cc
[modify] https://crrev.com/3b6aeffa075816129e32e57412b1c89ba619df10/ui/views/widget/desktop_aura/x11_desktop_handler.h

Comment 2 by thomasanderson@chromium.org, Aug 26 2016

Status: Fixed (was: Started)
►

Sign in to add a comment