New issue
Advanced search Search tips

Issue 635167 link

Starred by 5 users

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 630357
issue 635166



Sign in to add a comment

Harmony - updates to contents of bubbles

Project Member Reported by est...@chromium.org, Aug 5 2016

Issue description

Some bubbles are getting major overhauls. Those should be tracked independently. For launching Harmony I think it should be enough to update what we have. Manual updates will be necessary:

a) all buttons should switch to the new style (there are factory functions in MdTextButton to make this easier to synchronize with the --secondary-ui-md flag)
b) other random stuff like the [x] button in the password save bubble's list of passwords should reuse MD assets. (In this example, it should probably match the [x] in the find in page bar.)

It will require a fine toothed comb and a lot of investigation to find all the bubbles and dialogs and see if their contents need changing. Luckily, most controls should be updated for "free": the action buttons, the window close button, and all the controls which we're updating in place (i.e. don't require changes to the call site) will automatically update as we address those tasks.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec38c1703b3bff054b6a45869a6699f86aadb07b

commit ec38c1703b3bff054b6a45869a6699f86aadb07b
Author: estade <estade@chromium.org>
Date: Thu Sep 01 20:55:45 2016

Partially update TranslateBubbleView for Harmony controls.

Should have no effect unless you pass --secondary-ui-md.

BUG= 635167 

Review-Url: https://codereview.chromium.org/2294203002
Cr-Commit-Position: refs/heads/master@{#416050}

[modify] https://crrev.com/ec38c1703b3bff054b6a45869a6699f86aadb07b/chrome/browser/ui/views/translate/translate_bubble_view.cc

Project Member

Comment 2 by sheriffbot@chromium.org, Sep 4 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: UI>Browser>Bubbles
Status: Archived (was: Untriaged)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment