views::Combobox needs updates for Harmony, but like Textfield I think the differences are relatively minor. I could be wrong; it warrants investigation. The most noticeable difference is probably the addition of a ripple.
Assigning this to you - you are the best person to make tweaks on controls.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09c613b3490b2cfefc57d352534fa0ae76e3b148 commit 09c613b3490b2cfefc57d352534fa0ae76e3b148 Author: estade <estade@chromium.org> Date: Tue Aug 09 18:31:21 2016 Implement Harmony textfield border In case it's unfamiliar, "Harmony" is the name of the version of MD we're using for secondary UI in chrome (dialogs, bubbles, etc.). BUG= 635164 , 635160 Review-Url: https://codereview.chromium.org/2228593002 Cr-Commit-Position: refs/heads/master@{#410754} [modify] https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148/ui/views/cocoa/bridged_native_widget_unittest.mm [modify] https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148/ui/views/controls/focusable_border.cc [modify] https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148/ui/views/controls/focusable_border.h [modify] https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148/ui/views/examples/textfield_example.cc [modify] https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148/ui/views/examples/textfield_example.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76d2f690c72864d90d77b3157e72b2a8f8cf0f72 commit 76d2f690c72864d90d77b3157e72b2a8f8cf0f72 Author: estade <estade@chromium.org> Date: Thu Sep 01 23:13:43 2016 Add ink drop ripple (but no highlight) to comboboxes in harmony. Also separate PrefixDelegate from View inheritance. I thought this step would be necessary for this CL. Turns out it isn't, but it still seems like an improvement. BUG= 635164 Review-Url: https://codereview.chromium.org/2289143004 Cr-Commit-Position: refs/heads/master@{#416110} [modify] https://crrev.com/76d2f690c72864d90d77b3157e72b2a8f8cf0f72/ui/views/controls/combobox/combobox.cc [modify] https://crrev.com/76d2f690c72864d90d77b3157e72b2a8f8cf0f72/ui/views/controls/combobox/combobox.h [modify] https://crrev.com/76d2f690c72864d90d77b3157e72b2a8f8cf0f72/ui/views/controls/menu/submenu_view.cc [modify] https://crrev.com/76d2f690c72864d90d77b3157e72b2a8f8cf0f72/ui/views/controls/menu/submenu_view.h [modify] https://crrev.com/76d2f690c72864d90d77b3157e72b2a8f8cf0f72/ui/views/controls/prefix_delegate.h [modify] https://crrev.com/76d2f690c72864d90d77b3157e72b2a8f8cf0f72/ui/views/controls/prefix_selector.cc [modify] https://crrev.com/76d2f690c72864d90d77b3157e72b2a8f8cf0f72/ui/views/controls/prefix_selector.h [modify] https://crrev.com/76d2f690c72864d90d77b3157e72b2a8f8cf0f72/ui/views/controls/prefix_selector_unittest.cc [modify] https://crrev.com/76d2f690c72864d90d77b3157e72b2a8f8cf0f72/ui/views/controls/tree/tree_view.cc [modify] https://crrev.com/76d2f690c72864d90d77b3157e72b2a8f8cf0f72/ui/views/controls/tree/tree_view.h [modify] https://crrev.com/76d2f690c72864d90d77b3157e72b2a8f8cf0f72/ui/views/examples/combobox_example.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f34ffe26c30eb268f62a0240fb442afdebce5d67 commit f34ffe26c30eb268f62a0240fb442afdebce5d67 Author: estade <estade@chromium.org> Date: Tue Sep 06 15:47:20 2016 Update Harmony textfield and combobox default border color. BUG= 635160 , 635164 Review-Url: https://codereview.chromium.org/2302173002 Cr-Commit-Position: refs/heads/master@{#416629} [modify] https://crrev.com/f34ffe26c30eb268f62a0240fb442afdebce5d67/ui/native_theme/common_theme.cc [modify] https://crrev.com/f34ffe26c30eb268f62a0240fb442afdebce5d67/ui/views/controls/button/checkbox.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/231e59374ebcdb6d76c9ac282ef7989385a3e1b1 commit 231e59374ebcdb6d76c9ac282ef7989385a3e1b1 Author: estade <estade@chromium.org> Date: Wed Sep 07 00:22:31 2016 Harmony - manually draw combobox arrows. This takes care to draw arrows nicely at fractional scale factors. It also improves border drawing at fractional scales. BUG= 635164 Review-Url: https://codereview.chromium.org/2314983003 Cr-Commit-Position: refs/heads/master@{#416793} [modify] https://crrev.com/231e59374ebcdb6d76c9ac282ef7989385a3e1b1/ui/views/controls/combobox/combobox.cc [modify] https://crrev.com/231e59374ebcdb6d76c9ac282ef7989385a3e1b1/ui/views/controls/focusable_border.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/535dfe7eacd0c1ac003859cf18a81297f508ad5a commit 535dfe7eacd0c1ac003859cf18a81297f508ad5a Author: estade <estade@chromium.org> Date: Wed Sep 07 22:23:13 2016 More Harmony combobox/textfield updates: Textfields: - handle disabled state for text, border Comboboxes: - update enabled text color (matches textfield) - handle disabled state for text, arrow, border (matches textfield) - draw a solid background so that subpixel aa works BUG= 644709 , 635164 , 635160 Review-Url: https://codereview.chromium.org/2319193002 Cr-Commit-Position: refs/heads/master@{#417093} [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/native_theme/common_theme.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/controls/combobox/combobox.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/controls/combobox/combobox.h [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/controls/focusable_border.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/examples/textfield_example.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/examples/textfield_example.h
More or less done. Any further tweaks can be tracked in more specific bugs.
Comment 1 by est...@chromium.org
, Aug 5 2016