New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635160 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 630357
issue 622419



Sign in to add a comment

Harmony - textfields

Project Member Reported by est...@chromium.org, Aug 5 2016

Issue description

Differences are relatively minor and probably all have to do with the border. 1px instead of 1dp border, perhaps other slight tweaks like corner radius, padding values, colors?

shrike@ suggested Elly for this task.
 
Blocking: 622419
Owner: est...@chromium.org
I had suggested elljyjones@ implement half the Harmony controls, not correct problems with things you've already implemented. Since you have done almost all the work on this control you are the best person to bring it completely up to spec.

Cc: shrike@chromium.org bettes@chromium.org
The hint text color is too light. In screenshot, top is current implementation, bottom is sticker sheet.


Screen Shot 2016-08-09 at 11.26.53 AM.png
23.7 KB View Download

Comment 5 by bettes@chromium.org, Aug 10 2016

"hint text: 12pt system Regular #969696"

https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)#%2FSPEC-secondary-UI-03-dropdown-texfileds.png
SPEC-secondary-UI-03-dropdown-texfileds.png
127 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 6 2016

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1aeb79d7883f1f75729c452ece42137b991a0d40

commit 1aeb79d7883f1f75729c452ece42137b991a0d40
Author: estade <estade@chromium.org>
Date: Wed Sep 07 04:13:28 2016

Harmony - set correct textfield placeholder text color

Derive the placeholder text color from the normal text color
instead of hardcoding or adding another constant to NativeTheme. This
should handle unusual color schemes (like light text on a dark bg) well.
In the normal case of \#333 default text on a white bg, this comes out to the
spec'd value of \#969696.

BUG= 635160 

Review-Url: https://codereview.chromium.org/2313123002
Cr-Commit-Position: refs/heads/master@{#416843}

[modify] https://crrev.com/1aeb79d7883f1f75729c452ece42137b991a0d40/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/1aeb79d7883f1f75729c452ece42137b991a0d40/ui/views/controls/textfield/textfield.h

Comment 9 by est...@chromium.org, Oct 28 2016

Status: Fixed (was: Assigned)
More or less done. Any further tweaks can be tracked in more specific bugs.

Sign in to add a comment