Harmony - textfields |
||||
Issue descriptionDifferences are relatively minor and probably all have to do with the border. 1px instead of 1dp border, perhaps other slight tweaks like corner radius, padding values, colors? shrike@ suggested Elly for this task.
,
Aug 7 2016
I had suggested elljyjones@ implement half the Harmony controls, not correct problems with things you've already implemented. Since you have done almost all the work on this control you are the best person to bring it completely up to spec.
,
Aug 9 2016
The hint text color is too light. In screenshot, top is current implementation, bottom is sticker sheet.
,
Aug 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09c613b3490b2cfefc57d352534fa0ae76e3b148 commit 09c613b3490b2cfefc57d352534fa0ae76e3b148 Author: estade <estade@chromium.org> Date: Tue Aug 09 18:31:21 2016 Implement Harmony textfield border In case it's unfamiliar, "Harmony" is the name of the version of MD we're using for secondary UI in chrome (dialogs, bubbles, etc.). BUG= 635164 , 635160 Review-Url: https://codereview.chromium.org/2228593002 Cr-Commit-Position: refs/heads/master@{#410754} [modify] https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148/ui/views/cocoa/bridged_native_widget_unittest.mm [modify] https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148/ui/views/controls/focusable_border.cc [modify] https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148/ui/views/controls/focusable_border.h [modify] https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148/ui/views/examples/textfield_example.cc [modify] https://crrev.com/09c613b3490b2cfefc57d352534fa0ae76e3b148/ui/views/examples/textfield_example.h
,
Aug 10 2016
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f34ffe26c30eb268f62a0240fb442afdebce5d67 commit f34ffe26c30eb268f62a0240fb442afdebce5d67 Author: estade <estade@chromium.org> Date: Tue Sep 06 15:47:20 2016 Update Harmony textfield and combobox default border color. BUG= 635160 , 635164 Review-Url: https://codereview.chromium.org/2302173002 Cr-Commit-Position: refs/heads/master@{#416629} [modify] https://crrev.com/f34ffe26c30eb268f62a0240fb442afdebce5d67/ui/native_theme/common_theme.cc [modify] https://crrev.com/f34ffe26c30eb268f62a0240fb442afdebce5d67/ui/views/controls/button/checkbox.cc
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1aeb79d7883f1f75729c452ece42137b991a0d40 commit 1aeb79d7883f1f75729c452ece42137b991a0d40 Author: estade <estade@chromium.org> Date: Wed Sep 07 04:13:28 2016 Harmony - set correct textfield placeholder text color Derive the placeholder text color from the normal text color instead of hardcoding or adding another constant to NativeTheme. This should handle unusual color schemes (like light text on a dark bg) well. In the normal case of \#333 default text on a white bg, this comes out to the spec'd value of \#969696. BUG= 635160 Review-Url: https://codereview.chromium.org/2313123002 Cr-Commit-Position: refs/heads/master@{#416843} [modify] https://crrev.com/1aeb79d7883f1f75729c452ece42137b991a0d40/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/1aeb79d7883f1f75729c452ece42137b991a0d40/ui/views/controls/textfield/textfield.h
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/535dfe7eacd0c1ac003859cf18a81297f508ad5a commit 535dfe7eacd0c1ac003859cf18a81297f508ad5a Author: estade <estade@chromium.org> Date: Wed Sep 07 22:23:13 2016 More Harmony combobox/textfield updates: Textfields: - handle disabled state for text, border Comboboxes: - update enabled text color (matches textfield) - handle disabled state for text, arrow, border (matches textfield) - draw a solid background so that subpixel aa works BUG= 644709 , 635164 , 635160 Review-Url: https://codereview.chromium.org/2319193002 Cr-Commit-Position: refs/heads/master@{#417093} [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/native_theme/common_theme.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/controls/combobox/combobox.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/controls/combobox/combobox.h [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/controls/focusable_border.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/examples/textfield_example.cc [modify] https://crrev.com/535dfe7eacd0c1ac003859cf18a81297f508ad5a/ui/views/examples/textfield_example.h
,
Oct 28 2016
More or less done. Any further tweaks can be tracked in more specific bugs. |
||||
►
Sign in to add a comment |
||||
Comment 1 by est...@chromium.org
, Aug 5 2016