New issue
Advanced search Search tips

Issue 635158 link

Starred by 5 users

Issue metadata

Status: Duplicate
Merged: issue 691891
Owner: ----
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 630357



Sign in to add a comment

Harmony - typography

Project Member Reported by est...@chromium.org, Aug 5 2016

Issue description

We need to make sure all text is an appropriate size. We size text via delta from a base value (normally, the base value is 12, so if you see a mock that specifies 14, that's a delta of 2).

There are constants sprinkled throughout the code, and there are ui::ResourceBundle size delta constants, and there is a font style enum that is deprecated and hopefully can be deleted. We need to do something here that is sane, consistent and maintainable.

There are also weight differences across different surfaces, but usually that should be part of the base implementation and instances should never have to worry about changing it (e.g. buttons have Medium weight).

See also  bug 633986 
 
When discussing this with Sebastien and Alex in the past, I asked them to consider this issue keeping in mind users with much larger fonts (for accessibility reasons).  It wasn't obvious whether we always wanted do something like "large font is normal font + 2" vs. "large font is normal font + 20%".

The enum I can think of relating to size (base font, large font, etc.) was in hopes that people would never specify any sizes, in either absolute or relative terms, anywhere in the codebase, but always use one of these enums.  This would ensure we used a small number of distinct font sizes everywhere, and we could make a decision once about how to handle things like super-large system fonts and not have to decided on a case-by-case basis.  I still think that's a desirable way to go, but we seemed to move away from it (and away from accessibility) in MD when we began forcing font sizes to be exact numeric values.
Cc: tapted@chromium.org
see also  https://codereview.chromium.org/1689623004

Comment 3 by bettes@chromium.org, Aug 11 2016

Just so I understand, the font style enum of base, large, etc that is now deprecated and we need to decide wither we should be using absolute numbers or percentages when handling large fonts? 

Comment 4 by est...@chromium.org, Aug 11 2016

We want to create semantic categories for font size, as you have already depicted in your typography spec sheet, so instead of "small/normal/medium/large" we have "normal text/Header text/etc". I think for now it's ok for you to continue to specify these in absolute sizes like 12, 14, etc., with the understanding that 12 actually means "default font size" and other numbers actually mean "default font size + (X - 12)". What Peter is suggesting is that we may want that to actually be "default font size * (X / 12)", but I think that's more of a question for accessibility to answer rather than design. 

Personally, I think it's better to stick with adding a constant because if people turn their font sizes up it's probably more that they want their small text surfaces to be larger/more readable and not because they need already large text to be exceptionally large.

Comment 5 by hwi@chromium.org, Aug 11 2016

Cc: lpalmaro@chromium.org
+lpalmaro@ for feedback
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 14 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by tapted@chromium.org, Aug 16 2017

Mergedinto: 691891
Status: Duplicate (was: Untriaged)
I think stuff discussed here is all covered by  Issue 691891 

Sign in to add a comment