Harmony - radio and checkbox buttons |
|||
Issue descriptionI started these already, see https://codereview.chromium.org/2026833003 https://codereview.chromium.org/2032683003 I think all that's left may be to animate between states?
,
Aug 9 2016
Also the "unchecked" state is too light.
,
Aug 9 2016
Radio button focus state is wrong (current on left, sticker sheet on right).
,
Aug 9 2016
Checkbox has similar problems: - square border instead of rounded rect - incorrect focus state - unchecked state too light
,
Aug 10 2016
Hey guys, I've updated the radio/checkbox specs. Please take a look and let me know if there's any resolved questions. unchecked-color: #5a5a5a checked-color: #4285F4
,
Aug 10 2016
,
Aug 11 2016
The colors that you noticed Jayson are only wrong on Mac. We're using kColorId_FocusedBorderColor, and on non-Mac Views that's #4285F4 which is the sticker sheet color. You should file a bug for a Mac-specific fix here. I'm not really sure what you mean about the inner circle having a rough edge. Both the sticker sheet and the implementation seem to look very similar in your screenshots, modulo color. I have a patch underway for the other issues.
,
Aug 11 2016
I will file a bug on the color on the Mac. Re: the inner circle, the sticker sheet and implementation look very different. The implementation version is basically a square with some fuzz around it, and at scale it looks like poorly anti-aliased circle. The four corners of this square need to be lighter in order to match the sticker sheet.
,
Aug 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed836b02166a6f4ee65657137dc4577c99a2715b commit ed836b02166a6f4ee65657137dc4577c99a2715b Author: estade <estade@chromium.org> Date: Mon Aug 15 19:24:51 2016 Harmony checkbox/radio tweaks a) new focus ring is 2dp and somewhat transparent b) adjustments to text and icon coloration BUG= 635156 Review-Url: https://codereview.chromium.org/2240603002 Cr-Commit-Position: refs/heads/master@{#412015} [modify] https://crrev.com/ed836b02166a6f4ee65657137dc4577c99a2715b/ui/native_theme/common_theme.cc [modify] https://crrev.com/ed836b02166a6f4ee65657137dc4577c99a2715b/ui/views/controls/button/checkbox.cc [modify] https://crrev.com/ed836b02166a6f4ee65657137dc4577c99a2715b/ui/views/controls/button/checkbox.h [modify] https://crrev.com/ed836b02166a6f4ee65657137dc4577c99a2715b/ui/views/controls/button/label_button.cc [modify] https://crrev.com/ed836b02166a6f4ee65657137dc4577c99a2715b/ui/views/controls/button/label_button_unittest.cc [modify] https://crrev.com/ed836b02166a6f4ee65657137dc4577c99a2715b/ui/views/controls/button/radio_button.cc [modify] https://crrev.com/ed836b02166a6f4ee65657137dc4577c99a2715b/ui/views/controls/button/radio_button.h
,
Aug 15 2016
regarding the inner circle --- this is controlled by a .icon file, i.e. taken from an SVG provided by Sebastien, so if Alan agrees it should be changed he should provide a new svg. Same goes for any tweaks to checkmark.
,
Aug 16 2016
Evan, can you point me to the svg's being used?
,
Aug 16 2016
see zip file attached to this comment: https://bugs.chromium.org/p/chromium/issues/detail?id=609922#c3
,
Oct 1 2016
,
Oct 28 2016
More or less done. Any further tweaks can be tracked in more specific bugs. |
|||
►
Sign in to add a comment |
|||
Comment 1 by shrike@chromium.org
, Aug 9 20162.0 KB
2.0 KB View Download
15.6 KB
15.6 KB View Download