New issue
Advanced search Search tips

Issue 635151 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 635153

Blocking:
issue 630357



Sign in to add a comment

Harmony - updates to text buttons (MdTextButton)

Project Member Reported by est...@chromium.org, Aug 5 2016

Issue description

MdTextButton should be mainly finished, but someone needs to make sure there aren't minor differences to Alan's spec.

Also there are TODOs around drawing more colors from the NativeTheme.

Also, the visuals for "Default" are still in flux.
 
Blockedon: 635153

Comment 3 by est...@chromium.org, Aug 16 2016

That default seems kind of weird to me; it looks half-disabled. The fact it matches hover is confusing because in many places we reuse the same effect for hover and focus. Granted, we use a blue ring for focus here, but as a user I might reasonably look at a default button and think it was the focused button.

I'm still holding out hope that we'd not have a default that was separate from call to action, i.e., all dialogs would get call to action styling on their default buttons. Has that already been rejected?
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c4e09087ab718cc98ca7917fa7e27eca359b0b1

commit 7c4e09087ab718cc98ca7917fa7e27eca359b0b1
Author: estade <estade@chromium.org>
Date: Sun Aug 21 01:05:34 2016

Adjust MdTextButton border calculation.

Buttons should normally be 28dp tall. Other scenarios with bigger than
usual text require adjustment to that value.

BUG= 635151 

Review-Url: https://codereview.chromium.org/2256403002
Cr-Commit-Position: refs/heads/master@{#413357}

[modify] https://crrev.com/7c4e09087ab718cc98ca7917fa7e27eca359b0b1/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/7c4e09087ab718cc98ca7917fa7e27eca359b0b1/ui/views/controls/button/md_text_button.h

Comment 7 by est...@chromium.org, Oct 28 2016

Status: Fixed (was: Assigned)
More or less done. Any further tweaks can be tracked in more specific bugs.

Sign in to add a comment