DevTools: [HostedMode] fetch protocol files with respect to front-end checkout, not browser |
||||
Issue descriptionToday, we fetch InspectorBackendCommands wrt running browser version. This causes front-end fatal exceptions when the browser differs from front-end. Instead, we should fetch InspectorBackendCommands wrt devtools front-end version. In this case, the only errors that will possibly happen are "unknown protocol command" - which should be handled by front-end code anyway.
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/846251ff8e503e1a90ce93a5119d32010e8c872f commit 846251ff8e503e1a90ce93a5119d32010e8c872f Author: chenwilliam <chenwilliam@chromium.org> Date: Fri Aug 12 18:47:12 2016 DevTools: Override browser commit hash with process.env.CHROMIUM_COMMIT This is a simple solution for hosted mode users who want to override which version of the proxied files (SupportedCSSProperties.js and InspectorBackendCommands.js) they want to use, instead of relying on the default which gets the commit hash of the browser/back-end. Example: CHROMIUM_COMMIT=813208daf9e9821657e55ef7c40a14815efdcf49 npm run server Will update docs after this lands. Added a comment to the bug issue for more context on why we used this approach. BUG= 635136 Review-Url: https://codereview.chromium.org/2236733002 Cr-Commit-Position: refs/heads/master@{#411721} [modify] https://crrev.com/846251ff8e503e1a90ce93a5119d32010e8c872f/third_party/WebKit/Source/devtools/scripts/hosted_mode/server.js
,
Aug 12 2016
,
Sep 29 2016
,
Sep 29 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by chenwilliam@chromium.org
, Aug 10 2016