New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 635130 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ui::ET_GESTURE_WIN8_EDGE_SWIPE appears unused

Project Member Reported by jamescook@chromium.org, Aug 5 2016

Issue description

It's referenced in the code, but we don't seem to synthesize them anymore.

It was added in https://codereview.chromium.org/143023003 for Metro mode, but the class that synthesized them doesn't exist any more.

 
Owner: jamescook@chromium.org
Status: Started (was: Untriaged)
Actually, I'm working on a CL that removes a couple of these references, so I'll just clean it up.

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6

commit 4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6
Author: jamescook <jamescook@chromium.org>
Date: Mon Aug 08 20:10:51 2016

mash: Remove ash::ShelfGestureHandler and ui::ET_GESTURE_WIN8_EDGE_SWIPE

ShelfGestureHandler uses aura windows and is a dependency of ShelfView.
We're moving ShelfView to wm common types.

* Fold ShelfGestureHandler into ShelfLayoutManager.
* Eliminate the event_target_window parameter from ProcessGestureEvent because
the shelf can look up its own root window.
* Eliminate unused ui::ET_GESTURE_WIN8_EDGE_SWIPE which existed to support
these gestures.

BUG= 629252 , 635130 
TEST=ash_unittests, manual tests of shelf gesture show/hide behavior

Review-Url: https://codereview.chromium.org/2224653002
Cr-Commit-Position: refs/heads/master@{#410416}

[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/ash.gyp
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/aura/wm_shelf_aura.h
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/common/system/status_area_widget_delegate.cc
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/shelf/shelf_bezel_event_filter.cc
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/shelf/shelf_bezel_event_filter.h
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/shelf/shelf_view.cc
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/shelf/shelf_view.h
[delete] https://crrev.com/a45b3efa3d3c194d01fda7ba030910831f81ffcf/ash/wm/gestures/shelf_gesture_handler.cc
[delete] https://crrev.com/a45b3efa3d3c194d01fda7ba030910831f81ffcf/ash/wm/gestures/shelf_gesture_handler.h
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/wm/immersive_fullscreen_controller.cc
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/wm/system_gesture_event_filter.cc
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ash/wm/system_gesture_event_filter.h
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ui/events/event.cc
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ui/events/event.h
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ui/events/event_constants.h
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ui/events/gesture_detection/gesture_touch_uma_histogram.cc
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ui/events/gesture_detection/gesture_touch_uma_histogram.h
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ui/events/test/event_generator.cc
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ui/events/test/event_generator.h
[modify] https://crrev.com/4d2dc47191a1fd200254a6b53b5d1e8f0fe49de6/ui/wm/core/compound_event_filter.cc

Status: Fixed (was: Started)

Sign in to add a comment