New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635129 link

Starred by 3 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Omnibox source code has hacker_case varialblles [Mac]

Project Member Reported by shrike@chromium.org, Aug 5 2016 
Code was recently added to omnibox_popup_cell.[h,mm] and omnibox_popup_matrix.mm that contains hacker_case style variables. When in ObjC code variables should follow camelCase.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ede179b31679b2e3de86fce9bc623c0dfc9dd98a

commit ede179b31679b2e3de86fce9bc623c0dfc9dd98a
Author: shrike <shrike@chromium.org>
Date: Tue Aug 09 16:45:23 2016

[Mac] Fix hacker_case problems in Omnibox source.

Recent changes to Mac Omnibox code include hacker_case variables and a
hacker_case method name (!!). This cl fixes those mistakes.

R=tapted@chromium.org
BUG= 635129 

Review-Url: https://codereview.chromium.org/2221613002
Cr-Commit-Position: refs/heads/master@{#410704}

[modify] https://crrev.com/ede179b31679b2e3de86fce9bc623c0dfc9dd98a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h
[modify] https://crrev.com/ede179b31679b2e3de86fce9bc623c0dfc9dd98a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm
[modify] https://crrev.com/ede179b31679b2e3de86fce9bc623c0dfc9dd98a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm

Comment 2 by shrike@chromium.org, Aug 9 2016

Status: Fixed (was: Started)
►

Sign in to add a comment