update.py may not sync lld up to the correct revision |
|||
Issue descriptionWe have observed on bots that update.py didn't sync lld up to the correct revision on Mac and Linux. This resulted and strange link and compiler errors and could have lead to a broken build. We need to investigate the cause of it. Tentatively assigning to myself.
,
Aug 5 2016
If we did, I missed that. Can you please point me to the relevant comment?
,
Aug 5 2016
,
Aug 5 2016
https://bugs.chromium.org/p/chromium/issues/detail?id=629966#c56 was a reply to https://bugs.chromium.org/p/chromium/issues/detail?id=629966#c54 and I missed https://bugs.chromium.org/p/chromium/issues/detail?id=629966#c55 completely. From your side it was impossible to distinguish. Sorry.
,
Aug 5 2016
As for the slave being correct. Here is the failed run: https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_upload_clang/builds/62 Notice myself as a requester and the slave (vm648-m4). And https://bugs.chromium.org/p/chromium/issues/detail?id=629966#c48 tells us about the same bot, chrome-bot@vm648-m4:(Mac 10.11.4). So, no, the issue is real.
,
Aug 5 2016
Ah, that's because you made the bots check out lld unconditionally, then I reverted that on https://codereview.chromium.org/2217113003/, but now the slaves that build with your change have a stale lld checkout still floating around.
,
Aug 5 2016
FWIW, Linux and Mac builds succeeded: https://codereview.chromium.org/2217763006 Windows build failed as expected.
,
Aug 5 2016
,
Aug 5 2016
,
Aug 5 2016
I buy this explanation. It also explains why this issue was isolated to Mac/Linux and did not touch Windows.
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2e30b8c230d923e61752352cf4c37eb13eea3d2 commit f2e30b8c230d923e61752352cf4c37eb13eea3d2 Author: thakis <thakis@chromium.org> Date: Fri Aug 05 23:16:12 2016 Make sure no stale LLD checkout is around. We checked out LLD for a while on all platforms, and now some bots have stale checkouts of it. See bug for details. BUG= 635108 Review-Url: https://codereview.chromium.org/2220113002 Cr-Commit-Position: refs/heads/master@{#410206} [modify] https://crrev.com/f2e30b8c230d923e61752352cf4c37eb13eea3d2/tools/clang/scripts/update.py
,
Aug 5 2016
,
Aug 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1d17ef355294fe1ad2f624711869003a3ded893 commit d1d17ef355294fe1ad2f624711869003a3ded893 Author: krasin <krasin@chromium.org> Date: Sat Aug 06 01:32:15 2016 Revert of Make sure no stale LLD checkout is around. (patchset #1 id:1 of https://codereview.chromium.org/2220113002/ ) Reason for revert: Breaks clang_upload bot: OSError: [Errno 2] No such file or directory: '/b/build/slave/linux_upload_clang/build/src/third_party/llvm/tools/lld' It seems that RmTree requires the directory to exist. Original issue's description: > Make sure no stale LLD checkout is around. > > We checked out LLD for a while on all platforms, and now some bots > have stale checkouts of it. See bug for details. > > BUG= 635108 > > Committed: https://crrev.com/f2e30b8c230d923e61752352cf4c37eb13eea3d2 > Cr-Commit-Position: refs/heads/master@{#410206} TBR=thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 635108 Review-Url: https://codereview.chromium.org/2218313002 Cr-Commit-Position: refs/heads/master@{#410247} [modify] https://crrev.com/d1d17ef355294fe1ad2f624711869003a3ded893/tools/clang/scripts/update.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Aug 5 2016