New issue
Advanced search Search tips

Issue 635048 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add a drop shadow to error banners

Project Member Reported by bettes@chromium.org, Aug 5 2016

Issue description

Create some separation between banner and manager surface with a drop shadow: 

shadow: 0px 1px 2px 0px rgba(0,0,0,.12)


Updated spec:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_manager/spec#%2FSPEC%20-%20components.png

 
Screen Shot 2016-08-05 at 1.00.59 PM.png
342 KB View Download
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0

commit b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0
Author: mahmadi <mahmadi@chromium.org>
Date: Tue Aug 09 20:00:45 2016

MD User Manager: Changes to 'import supervised users' dialog.

1. Shows the 'no supervised users to import' message in the error banner instead.
2. Adds a shadow to the banner for better separation from the content area.
3. Changes paper-listbox's selected item style to Polymer's default.

BUG= 635043 ,  635048 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2223743003
Cr-Commit-Position: refs/heads/master@{#410784}

[modify] https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0/chrome/browser/resources/md_user_manager/create_profile.html
[modify] https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0/chrome/browser/resources/md_user_manager/create_profile.js
[modify] https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0/chrome/browser/resources/md_user_manager/import_supervised_user.html
[modify] https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0/chrome/browser/resources/md_user_manager/import_supervised_user.js
[modify] https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0/chrome/test/data/webui/md_user_manager/create_profile_tests.js
[modify] https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0/chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js

Status: Fixed (was: Started)

Sign in to add a comment