Move dialog message to error banner pattern |
||
Issue descriptionActual: Clicking on the "import existing SU" on the add person screen prompts a dialog that has a null primary action. Expected: Remove the dialog pattern. Move the body copy of the dialog to our existing error banner pattern.
,
Aug 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0 commit b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0 Author: mahmadi <mahmadi@chromium.org> Date: Tue Aug 09 20:00:45 2016 MD User Manager: Changes to 'import supervised users' dialog. 1. Shows the 'no supervised users to import' message in the error banner instead. 2. Adds a shadow to the banner for better separation from the content area. 3. Changes paper-listbox's selected item style to Polymer's default. BUG= 635043 , 635048 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2223743003 Cr-Commit-Position: refs/heads/master@{#410784} [modify] https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0/chrome/browser/resources/md_user_manager/create_profile.html [modify] https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0/chrome/browser/resources/md_user_manager/create_profile.js [modify] https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0/chrome/browser/resources/md_user_manager/import_supervised_user.html [modify] https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0/chrome/browser/resources/md_user_manager/import_supervised_user.js [modify] https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0/chrome/test/data/webui/md_user_manager/create_profile_tests.js [modify] https://crrev.com/b9c0f2f1f51a2c6566b6d1c51339ce055ecf2de0/chrome/test/data/webui/md_user_manager/import_supervised_user_tests.js
,
Aug 9 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by mahmadi@chromium.org
, Aug 5 2016