Does UseCounter::DocumentBeforeUnloadFired mess up frame vs subframes? |
||
Issue descriptionThis came up during a code review: https://codereview.chromium.org/2205523004/#msg10 In EventTarget::fireEventListeners(Event*, EventTargetData*, EventListenerVector&), UseCounter::DocumentBeforeUnloadFired is counted under the condition: if (executingWindow->top()) which used to be: if (executingWindow != executingWindow->top()) before https://codereview.chromium.org/22564003. Any chance the original was more accurate in terms of frame vs subframe distinction?
,
Aug 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d7dac7ca90eb803aa238e09ee6a183338e216c8 commit 7d7dac7ca90eb803aa238e09ee6a183338e216c8 Author: bokan <bokan@chromium.org> Date: Tue Aug 09 07:13:00 2016 Fix UseCounter for SubframeBeforeUnloadFired. The condition used to check whether the window is a subframe or not was wrong. It was originally `executingWindow != executingWindow->top()` but got accidentally changed in https://codereview.chromium.org/22564003. This CL fixes that error. BUG= 635029 Review-Url: https://codereview.chromium.org/2229543002 Cr-Commit-Position: refs/heads/master@{#410604} [modify] https://crrev.com/7d7dac7ca90eb803aa238e09ee6a183338e216c8/third_party/WebKit/Source/core/events/EventTarget.cpp [modify] https://crrev.com/7d7dac7ca90eb803aa238e09ee6a183338e216c8/third_party/WebKit/Source/web/tests/WebViewTest.cpp
,
Aug 9 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by bokan@chromium.org
, Aug 8 2016Status: Started (was: Available)