New issue
Advanced search Search tips

Issue 635028 link

Starred by 2 users
Status: Fixed
Owner:
pwnall@chromium.org
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Remove XP-specific workaround from browser_main_runner.cc

Project Member Reported by pwnall@chromium.org, Aug 5 2016 
Version: master
OS: Windows XP :P

(1) Open up content/browser/browser_main_runner.cc in CodeSearch or an editor -- https://cs.chromium.org/chromium/src/content/browser/browser_main_runner.cc?q=browser_main_runner.cc&sq=package:chromium&l=91
(2) Search for "Windows XP"

What is the expected output?
No match, since we don't support XP anymore.

What do you see instead?
We still have a workaround for a Windows XP bug.

Please use labels and text to provide additional information.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fd27ddeb13974b24cfa42261b940f8de378117a

commit 9fd27ddeb13974b24cfa42261b940f8de378117a
Author: pwnall <pwnall@chromium.org>
Date: Sun Nov 13 05:30:52 2016

Remove Windows XP cruft in browser_main_runner.cc

BUG= 635028 

Review-Url: https://codereview.chromium.org/2218783003
Cr-Commit-Position: refs/heads/master@{#431801}

[modify] https://crrev.com/9fd27ddeb13974b24cfa42261b940f8de378117a/content/browser/browser_main_runner.cc

Comment 2 by pwnall@chromium.org, Nov 13 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment