CronetUrlRequestTest#testFailures is flaky |
|||
Issue descriptionCronetUrlRequestTest#testFailures is flaky. We need to investigate and re-enable it.
,
Aug 30 2016
,
Aug 30 2016
6cbd5: 08-30 06:56:17.461 28784 28829 E AndroidRuntime: FATAL EXCEPTION: Thread-967 6cbd5: 08-30 06:56:17.461 28784 28829 E AndroidRuntime: Process: org.chromium.net, PID: 28784 6cbd5: 08-30 06:56:17.461 28784 28829 E AndroidRuntime: junit.framework.ComparisonFailure: expected:<[Exception received from UrlRequest.Callback]> but was:<[System error]> 6cbd5: 08-30 06:56:17.461 28784 28829 E AndroidRuntime: at junit.framework.Assert.assertEquals(Assert.java:85) 6cbd5: 08-30 06:56:17.461 28784 28829 E AndroidRuntime: at junit.framework.Assert.assertEquals(Assert.java:91) 6cbd5: 08-30 06:56:17.461 28784 28829 E AndroidRuntime: at org.chromium.net.TestUrlRequestCallback.onFailed(TestUrlRequestCallback.java:224) 6cbd5: 08-30 06:56:17.461 28784 28829 E AndroidRuntime: at org.chromium.net.JavaUrlRequest$AsyncUrlRequestCallback$7.run(JavaUrlRequest.java:834) 6cbd5: 08-30 06:56:17.461 28784 28829 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113) 6cbd5: 08-30 06:56:17.461 28784 28829 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588) 6cbd5: 08-30 06:56:17.461 28784 28829 E AndroidRuntime: at org.chromium.net.TestUrlRequestCallback$ExecutorThreadFactory$1.run(TestUrlRequestCallback.java:79) 6cbd5: 08-30 06:56:17.461 28784 28829 E AndroidRuntime: at java.lang.Thread.run(Thread.java:818) 6cbd5: 08-30 06:56:17.463 918 3003 W ActivityManager: Error in app org.chromium.net running instrumentation ComponentInfo{org.chromium.net.tests/android.test.InstrumentationTestRunner}: 6cbd5: 08-30 06:56:17.463 918 3003 W ActivityManager: junit.framework.ComparisonFailure 6cbd5: 08-30 06:56:17.463 918 3003 W ActivityManager: junit.framework.ComparisonFailure: expected:<[Exception received from UrlRequest.Callback]> but was:<[System error]> The Java implementation is flaky. I will investigate.
,
Aug 30 2016
https://codereview.chromium.org/2292113002/
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd8d8d9b383908aa19602df995cdae3bf09ba484 commit bd8d8d9b383908aa19602df995cdae3bf09ba484 Author: xunjieli <xunjieli@chromium.org> Date: Wed Aug 31 21:37:17 2016 CronetUrlRequestTest#testFailures CronetUrlRequestTest#testFailures() simulates callback failures in each response step. However, the response step is not updated in onFailed, so maybeThrowCancelOrPause() will throw an exception again. This results in a flake in the Java implementation. This CL updates response step in TestUrlRequestCallback, and adds two more tests to make sure throwing exception or canceling does nothing in terminal callbacks (onFailed, onCanceled, onSucceeded) R=kapishnikov@chromium.org BUG= 635026 Review-Url: https://codereview.chromium.org/2292113002 Cr-Commit-Position: refs/heads/master@{#415764} [modify] https://crrev.com/bd8d8d9b383908aa19602df995cdae3bf09ba484/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java [modify] https://crrev.com/bd8d8d9b383908aa19602df995cdae3bf09ba484/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java
,
Sep 1 2016
Fixed hopefully.. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Aug 11 2016