New issue
Advanced search Search tips

Issue 635017 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 608535



Sign in to add a comment

MD Settings: Add mechanism to skip certain <settings-subpage> instances while searching.

Project Member Reported by dpa...@chromium.org, Aug 5 2016

Issue description

Repro steps: Search for any string.

Observe two assertion errors in the console, thrown by [1], originating from the internet_page.html <settings-animated-pages> instance (see screenshot where I added a few console.logs).

[1]https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/route.js?l=351
 
errors.png
41.8 KB View Download
Cc: steve...@chromium.org
Bisect range, https://chromium.googlesource.com/chromium/src/+log/fab3447f6dc8633b0468fc7f40031e122d339629..787f6ed6c2cf4a21e07841564fd6a573c777d3ef

I am pretty sure this is related to https://codereview.chromium.org/2188163003.

@stevenjb: internet_detail_page is firing a subpage-back event right after it is rendered

 ready: function() {
    if (!this.guid)
      this.close_(); // fires subpage-back
  },

I think this is related to what we talked earlier today. This subpage is a "dynamic" one, and the searching algorithm should not be rendering it in the background, it should be skipped instead, since it only makes sense when the user clicks on a specific network.
Owner: dpa...@chromium.org
Status: Assigned (was: Untriaged)
Ah, yes, because the internet detail page looks like gibberish without a guid specified, I have it go back to the main page when that happens. It's useful when relaunching chrome, but apologies if it caused you grief. Once I get the routing working with ?guid=xxxx now that Tommy's change is in (should be early next week), that should be less of a problem. That said, we really shouldn't be searching that page.


Status: Started (was: Assigned)
Summary: MD Settings: Add mechanism to skip certain <settings-subpage> instances while searching. (was: MD Settings: Searching triggers assertion errors on ChromeOS)
I am repurposing this bug to be more generic. This better reflects the source cause of what needs to be done.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a94b6f16b9117a502adda26eddd53ef95832c27

commit 3a94b6f16b9117a502adda26eddd53ef95832c27
Author: dpapad <dpapad@chromium.org>
Date: Mon Aug 08 20:24:21 2016

MD Settings: Tune searching algorithm to skip certain subpages.

 - Introducing a new CSS attribute 'skip-search' to mark elements that should be
   ignored.
 - Modifying searching algorithm, to skip such elements, both when searching but
   also when triggering a forced rendering.
 - Modify <settings-animated-pages> to carry over the 'skip-search' attribute
   from the <template is="dom-if"> to the <settings-subpage> stamped instance.
 - Remove settings-subpage's noAssociatedControl member variable since it is not
   necessary anymore.

BUG= 635017 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2217403002
Cr-Commit-Position: refs/heads/master@{#410432}

[modify] https://crrev.com/3a94b6f16b9117a502adda26eddd53ef95832c27/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/3a94b6f16b9117a502adda26eddd53ef95832c27/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/3a94b6f16b9117a502adda26eddd53ef95832c27/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/3a94b6f16b9117a502adda26eddd53ef95832c27/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/3a94b6f16b9117a502adda26eddd53ef95832c27/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/3a94b6f16b9117a502adda26eddd53ef95832c27/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/3a94b6f16b9117a502adda26eddd53ef95832c27/chrome/browser/resources/settings/search_settings.js
[modify] https://crrev.com/3a94b6f16b9117a502adda26eddd53ef95832c27/chrome/browser/resources/settings/settings_page/settings_animated_pages.js
[modify] https://crrev.com/3a94b6f16b9117a502adda26eddd53ef95832c27/chrome/browser/resources/settings/settings_page/settings_subpage.js

Status: Fixed (was: Started)
Status: Fixed (was: Started)
Labels: VerifyIn-54
Labels: VerifyIn-55
Status: Verified (was: Fixed)
Verified on ChromeOS 8872.18.0, 55.0.2883.20

No console errors are seen when searched for a string in chrome://md-settings page.

Sign in to add a comment