New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 635012 link

Starred by 2 users
Status: Fixed
Owner:
█ wkorman@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
vmp...@chromium.org
chrishtr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression

Blocking:
issue 529938



Sign in to add a comment

Trace of cc.debug.display_items fails to load

Project Member Reported by schenney@chromium.org, Aug 5 2016 
Version: ToT, with RTree patch, git revision c57b829ff3345289ddfd92a305807d3a38908088
OS: Linux but probably all

What steps will reproduce the problem?
(1) Open LayoutTests/fast/borders/border-radius-with-composited-child.html
(2) Open tracing and record selecting cc.debug.display_items
(3) Switch back to the tab, back to tracing, stop tracing and wait

What is the expected output?
A Trace display with display item list information included

What do you see instead?
A popup with this message:
While importing:
Error: Missing layer rect
    at DisplayItemListSnapshot.initialize (chrome://tracing/tracing.js:5520:7)
    at DisplayItemListSnapshot.initialize (chrome://tracing/tracing.js:5522:147)
    at ObjectInstance.initialize (chrome://tracing/tracing.js:2261:19)
    at ObjectCollection.<anonymous> (chrome://tracing/tracing.js:2315:753)
    at Array.forEach (native)
    at Object.<anonymous> (chrome://tracing/tracing.js:2315:252)
    at Object.iterItems (chrome://tracing/tracing.js:902:139)
    at Object.<anonymous> (chrome://tracing/tracing.js:2315:196)
    at Object.iterItems (chrome://tracing/tracing.js:902:139)
    at ObjectCollection.iterObjectInstances (chrome://tracing/tracing.js:2315:127)

Comment 1 by wkorman@chromium.org, Aug 5 2016

Blocking: 529938

Comment 2 by wkorman@chromium.org, Aug 10 2016

Cc: chrishtr@chromium.org vmp...@chromium.org
Confirmed rtree patch introduces above issue, the layer rect in question is here:

https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/extras/chrome/cc/display_item_list.html?q=DisplayItemListSnapshot+initialize&sq=package:chromium&dr=C&l=17

After rtree patch there are no explicit layer bounds and the patch removed that key/value from the JSON representation, see DisplayItemList::AsValue in http://crrev.com/2225563002.

The closest equivalent in new world is the RTree bounds that contain all display items, so I'll revise patch to use that.

It's not quite a "layer_rect" with same semantics as previously, we could consider changing the name of the key, but it looks ok w.r.t. how it manifests in the tracing UI (it seems to just end up next to 'DisplayItemList (800x640)' for example).

There is no explicit patch to send for this bug as I'm just incorporating the fix into aforementioned change.

Comment 3 by wkorman@chromium.org, Aug 10 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment