New issue
Advanced search Search tips

Issue 635010 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 661680



Sign in to add a comment

Recipe roller adds too many reviewers to a CL and fails in git cl upload

Project Member Reported by tandrii@chromium.org, Aug 5 2016

Issue description

This is true for Gerrit https://build.chromium.org/p/chromium.infra.cron/builders/recipe-autoroller-public/builds/17172/steps/infra.git%20cl%20upload/logs/stdio

but it's also true for Rietveld if roll is really large. While it's a clear limitation of "git cl upload", "git cl" was never designed for this humongous number of reviewers. So, recipe roller has to be improved somehow.
 
Labels: -Restrict-View-Google
Labels: Pri-2
Labels: Type-Bug
Status: Available (was: Untriaged)
Blocking: 661680
Status: Fixed (was: Available)
roller now uses `git cl upload --r-owners` which uses the git-cl owners logic to pick sane reviewers. Any improvement for this should be done by improving git-cl now.

Sign in to add a comment