Issue metadata
Sign in to add a comment
|
security icon scheme coloring for iOS |
||||||||||||||||||||||||
Issue descriptionSome scheme colors are different on iOS. They should match the icon color: https://docs.google.com/document/d/1r0EEyAid7bAr1PLrFivQE3gCzFTXJH_9OvjjVi0VboE/edit (There was a similar bug but unrelated bug in Clank: https://bugs.chromium.org/p/chromium/issues/detail?id=626646)
,
Aug 5 2016
,
Aug 8 2016
Tentatively assigning to M54 and marking as Assigned since it has an owner. (Enamel sheriffing)
,
Aug 9 2016
This bug should also deal with the currently incorrect icon size and placement (see dupe bug https://bugs.chromium.org/p/chromium/issues/detail?id=634573) This is 53, it's blocking the new icons :(
,
Aug 18 2016
,
Aug 30 2016
Based on desktop, I am assuming that the scheme should *not* be highlighted for strikethrough HTTPS (desktop-scheme.png). This means I'm going with `gray-scheme.png` rather than `white-scheme.png` for strikethrough HTTPS. Correct me if that's wrong, Max.
,
Aug 30 2016
Screenshots for the CL. Screenshots are 6s+ to work around Issue 454529 (Origin in omnibox on iOS can be extremely small).
,
Aug 30 2016
CL is up at https://chromereviews.googleplex.com/494427013 (-3, +13) Gonna do what I can to get this landed and merged up to M53 with the icon changes.
,
Aug 30 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/4a9f24a823fd07670eef8ba5fb163368573ca870 commit 4a9f24a823fd07670eef8ba5fb163368573ca870 Author: lgarron <lgarron@google.com> Date: Tue Aug 30 16:54:48 2016
,
Aug 30 2016
Requesting a merge for 4a9f24a823fd07670eef8ba5fb163368573ca870 to M54. rohitrao@ informs me that this is probably too late for the first M53 cut, but there will be a follow-up cut next week that we can make. Will ask for an M53 later this week.
,
Aug 30 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Aug 30 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/87d57851a0f2c6bdbfafafde4e5e9a18cdb38ca4 commit 87d57851a0f2c6bdbfafafde4e5e9a18cdb38ca4 Author: lgarron <lgarron@google.com> Date: Tue Aug 30 16:54:48 2016
,
Aug 31 2016
,
Aug 31 2016
Is this considered fixed and ready for verification now that it has been merged?
,
Aug 31 2016
@lindsayw, yes, and we would also like to merge to M53 (cut 2) as well!
,
Aug 31 2016
Hi Emily, Sounds good, if you are ready for verification then please go ahead and mark it as fixed so it will surface in the list of fixed bugs ready for verification by testers. Thank you!
,
Aug 31 2016
Please make sure to merge this into the M53 branch 2785.
,
Aug 31 2016
,
Aug 31 2016
+eugenebut@, who has been kind enough to run the actual cherry-picking commands The current attempt failed because M54 is already beta and M53 is not yet stable in the eyes of cherry-pick-bot. Will try later this week.
,
Aug 31 2016
Failed cherry-picks (Googler-only links) to M53: go/bling-beta-cherry-picker/builds/886 (I'm not a commiter) go/bling-beta-cherry-picker/builds/887 (beta-stable limbo)
,
Aug 31 2016
Also, for the record, here are the M54 cherry-picks: go/bling-beta-cherry-picker/builds/883 (failed; I'm not a committer) go/bling-beta-cherry-picker/builds/884 (by eugenetbut@; success!)
,
Sep 1 2016
Verified the issue on the latest build 54.0.2840.9 beta tested on iPhone6(iOS 10 beta 8) and iPad(iOS 10 beta 8). All the security icon color looks good as per the doc.
,
Sep 1 2016
lgarron@ can you try merging again? rohitrao@ just added you as a commiter this morning.
,
Sep 2 2016
Cherry-picking to stable, which seems to have passed the branch check. The cherry-pick bots don't seem aligned with https://omahaproxy.appspot.com/ How do I check what the the bots think the branches are?
,
Sep 2 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/61b3bc53177d61eb5023950316775c9b366474a6 commit 61b3bc53177d61eb5023950316775c9b366474a6 Author: lgarron <lgarron@google.com> Date: Tue Aug 30 16:54:48 2016
,
Sep 12 2016
Verified on iPad Air (iOS 10 beta 8), iPhone 6S(iOS 9.3.5) on 53.0.2785.109 dev. All the security icon color looks match as mentioned in #17 and #7
,
Sep 12 2016
,
Sep 13 2016
Security icon colors looks as per the snapshots in #7 & #17. Verified on iPhone 6(9.3.5), iPad Air 2(10.0.1) in 55.0.2859.0 canary
,
Oct 19 2016
,
Nov 24 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by emilyschechter@chromium.org
, Aug 5 2016