New issue
Advanced search Search tips

Issue 634994 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

SystemGestureEventFilter and TouchUMA needs to be ported and split

Project Member Reported by sky@chromium.org, Aug 5 2016

Issue description

Parts of SystemGestureEventFilter should move to chrome (especially the parts that are calling to touchuma), other parts, such as calling to overview_gesture_handler_ should move to ash/common.
 
FYI, I'm going to remove the ShelfGestureHandler from SystemGestureEventFilter because it is only used for WIN8_EDGE_SWIPE and ash doesn't ship on Windows. Let me know if you need to keep it for some reason.

Comment 2 by sky@chromium.org, Aug 5 2016

SGTM, but I think SystemGestureEventFilter is used for more than just win8 stuff. It calls to TouchUMA for a couple of things, and it interacts with OverviewGestureHandler.

Comment 3 by sky@chromium.org, Aug 24 2016

Labels: Proj-Mustash-Mash
Components: MUS
Labels: Proj-Mustash
Components: Internals>MUS
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eca38d4605fa46a7822ca5522db352415d97eed4

commit eca38d4605fa46a7822ca5522db352415d97eed4
Author: sky <sky@chromium.org>
Date: Fri Mar 03 05:21:56 2017

chromeos: moves more ash tests to run on mash

And pointers to bugs for those that aren't moved to common.

BUG= 631103 , 633782 , 634994 , 648733 , 695887 , 696752 ,696754, 698016 , 698024 ,698032,698033, 698043 , 698049 ,698060,698085, 698092 ,698093, 698129 
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2732573002
Cr-Commit-Position: refs/heads/master@{#454514}

[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/BUILD.gn
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/focus_cycler_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/toast/toast_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/tooltips/tooltip_controller_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/workspace/workspace_window_resizer_unittest.cc

Can we close this assuming we are successful with in-process Mus?
We'll need to make sure SystemGestureEventFilter gets installed for mash. Right now it is skipped.

Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS
Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Status: Fixed (was: Untriaged)
Fixed with ws2.

Sign in to add a comment