New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 634984 link

Starred by 2 users
Status: Verified
Owner:
osh...@chromium.org
Closed: Aug 2016
Cc:
█ vadimt@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ARC++: send the initial desktop layout mode to arc.

Project Member Reported by osh...@chromium.org, Aug 5 2016 
We currently send only when it's changed. we need to send the initial state too.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4be485b1c22005792432569b13e15d7f5afde129

commit 4be485b1c22005792432569b13e15d7f5afde129
Author: oshima <oshima@chromium.org>
Date: Fri Aug 05 22:47:00 2016

Initialize layout_mode with the current value.

BUG= 634984 
TEST=manual. Go into tablet mode in login screen, then login, start arc apps.

Review-Url: https://codereview.chromium.org/2218973003
Cr-Commit-Position: refs/heads/master@{#410202}

[modify] https://crrev.com/4be485b1c22005792432569b13e15d7f5afde129/components/exo/wayland/server.cc

Comment 2 by osh...@chromium.org, Aug 5 2016

Status: Fixed (was: Started)

Comment 3 by osh...@chromium.org, Aug 6 2016

Labels: Merge-Request-53
Status: Started (was: Fixed)

Comment 4 by dimu@chromium.org, Aug 6 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29de4ed05c76cbd8a659fd4081a561e9ad31f86e

commit 29de4ed05c76cbd8a659fd4081a561e9ad31f86e
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Aug 08 16:44:13 2016

Initialize layout_mode with the current value.

BUG= 634984 
TEST=manual. Go into tablet mode in login screen, then login, start arc apps.

Review-Url: https://codereview.chromium.org/2218973003
Cr-Commit-Position: refs/heads/master@{#410202}
(cherry picked from commit 4be485b1c22005792432569b13e15d7f5afde129)

Review URL: https://codereview.chromium.org/2223973002 .

Cr-Commit-Position: refs/branch-heads/2785@{#527}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/29de4ed05c76cbd8a659fd4081a561e9ad31f86e/components/exo/wayland/server.cc

Comment 6 by osh...@chromium.org, Aug 8 2016

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83c9cfca3c9bce2a2afe703f5a9a7fc825799b7c

commit 83c9cfca3c9bce2a2afe703f5a9a7fc825799b7c
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Wed Aug 10 06:11:56 2016

Fix build breakage due to unmerged refactoring

BUG= 634984 
TEST=build exo/wayland locally on branch
TBR=takaoka@chromium.org

Review URL: https://codereview.chromium.org/2230803002 .

Cr-Commit-Position: refs/branch-heads/2785@{#547}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/83c9cfca3c9bce2a2afe703f5a9a7fc825799b7c/components/exo/wayland/server.cc

Comment 8 by abod...@chromium.org, Oct 5 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment