This way mash stays in sync with ash.
Issue 574270 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/778583e21002ef4a3a4d211772073db33d499aa0 commit 778583e21002ef4a3a4d211772073db33d499aa0 Author: sky <sky@chromium.org> Date: Fri Aug 05 19:53:29 2016 Adds WmShell::RecordGestureAction() mash isn't going to want all the constants defined in gesture_action_type, but the split can be done separately. I also didn't move TouchUMA directly as I believe most of that code needs to be moved to chrome and the renderer. BUG= 634972 TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2223553003 Cr-Commit-Position: refs/heads/master@{#410149} [modify] https://crrev.com/778583e21002ef4a3a4d211772073db33d499aa0/ash/ash.gyp [modify] https://crrev.com/778583e21002ef4a3a4d211772073db33d499aa0/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/778583e21002ef4a3a4d211772073db33d499aa0/ash/aura/wm_shell_aura.h [add] https://crrev.com/778583e21002ef4a3a4d211772073db33d499aa0/ash/common/metrics/gesture_action_type.h [modify] https://crrev.com/778583e21002ef4a3a4d211772073db33d499aa0/ash/common/wm_shell.h [modify] https://crrev.com/778583e21002ef4a3a4d211772073db33d499aa0/ash/frame/caption_buttons/frame_caption_button_container_view.cc [modify] https://crrev.com/778583e21002ef4a3a4d211772073db33d499aa0/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/778583e21002ef4a3a4d211772073db33d499aa0/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/778583e21002ef4a3a4d211772073db33d499aa0/ash/touch/touch_uma.cc [modify] https://crrev.com/778583e21002ef4a3a4d211772073db33d499aa0/ash/touch/touch_uma.h [modify] https://crrev.com/778583e21002ef4a3a4d211772073db33d499aa0/ash/wm/workspace/workspace_event_handler.cc [modify] https://crrev.com/778583e21002ef4a3a4d211772073db33d499aa0/chrome/browser/ui/views/touch_uma/touch_uma_ash.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/345a5bb94465b6090394ce89139d69968fb21f13 commit 345a5bb94465b6090394ce89139d69968fb21f13 Author: sky <sky@chromium.org> Date: Fri Aug 05 22:33:33 2016 Moves most frame related classes to ash/common/frame CustomFrameViewAsh requires a bit more surgery, and frame_border_hit_test_controller isn't needed for mash. BUG= 634972 TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2215223003 Cr-Commit-Position: refs/heads/master@{#410196} [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/ash.gyp [add] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/OWNERS [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/caption_buttons/caption_button_types.h [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/caption_buttons/frame_caption_button.cc [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/caption_buttons/frame_caption_button.h [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/caption_buttons/frame_caption_button_container_view.cc [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/caption_buttons/frame_caption_button_container_view.h [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/caption_buttons/frame_caption_button_container_view_unittest.cc [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/caption_buttons/frame_size_button.cc [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/caption_buttons/frame_size_button.h [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/caption_buttons/frame_size_button_delegate.h [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/default_header_painter.cc [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/default_header_painter.h [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/default_header_painter_unittest.cc [add] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/frame_border_hit_test.cc [add] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/frame_border_hit_test.h [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/header_painter.h [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/header_painter_util.cc [rename] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/common/frame/header_painter_util.h [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/frame/caption_buttons/frame_size_button_unittest.cc [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/frame/custom_frame_view_ash.cc [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/frame/custom_frame_view_ash_unittest.cc [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/frame/frame_border_hit_test_controller.cc [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/frame/frame_border_hit_test_controller.h [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/touch/touch_uma.cc [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/touch/touch_uma.h [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/ash/wm/panels/panel_frame_view.cc [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/chrome/browser/ui/views/frame/browser_header_painter_ash.cc [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/chrome/browser/ui/views/frame/browser_header_painter_ash.h [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/chrome/browser/ui/views/frame/web_app_left_header_view_ash.cc [modify] https://crrev.com/345a5bb94465b6090394ce89139d69968fb21f13/chrome/browser/ui/views/frame/web_app_left_header_view_ash_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fabae9f0be45c9ec0d729dd0d527291f2702817 commit 2fabae9f0be45c9ec0d729dd0d527291f2702817 Author: sky <sky@chromium.org> Date: Mon Aug 08 15:39:59 2016 Moves CustomFrameViewAsh to common As part of this I'm introducing a pure virtual interface for ImmersiveFullscreenController. I'm not entirely positive I'll need this interface long term, but I'll definitely need it in the short term. BUG= 634972 ,548435 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2222653002 Cr-Commit-Position: refs/heads/master@{#410363} [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/ash.gyp [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/aura/wm_shell_aura.cc [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/aura/wm_shell_aura.h [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/aura/wm_window_aura.cc [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/aura/wm_window_aura.h [rename] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/common/frame/custom_frame_view_ash.cc [rename] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/common/frame/custom_frame_view_ash.h [rename] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/common/frame/custom_frame_view_ash_unittest.cc [add] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/common/wm/immersive/wm_immersive_fullscreen_controller.h [add] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/common/wm/immersive/wm_immersive_fullscreen_controller_delegate.h [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/common/wm_shell.h [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/common/wm_window.h [delete] https://crrev.com/2405bb1097436a2405c843f483d3895ebe53db11/ash/frame/frame_border_hit_test_controller.cc [delete] https://crrev.com/2405bb1097436a2405c843f483d3895ebe53db11/ash/frame/frame_border_hit_test_controller.h [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/mus/bridge/wm_shell_mus.h [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/mus/bridge/wm_window_mus.cc [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/mus/bridge/wm_window_mus.h [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/shell.cc [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/wm/immersive_fullscreen_controller.cc [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/wm/immersive_fullscreen_controller.h [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/wm/immersive_fullscreen_controller_unittest.cc [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/wm/panels/panel_frame_view.cc [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/wm/panels/panel_frame_view.h [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/wm/resize_handle_window_targeter.cc [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/wm/resize_handle_window_targeter.h [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/wm/resize_shadow_and_cursor_unittest.cc [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/ash/wm/workspace/multi_window_resize_controller_unittest.cc [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h [modify] https://crrev.com/2fabae9f0be45c9ec0d729dd0d527291f2702817/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/039443070732a60fbdac74929cfbefc627c565d9 commit 039443070732a60fbdac74929cfbefc627c565d9 Author: sky <sky@chromium.org> Date: Mon Aug 08 21:14:33 2016 Fixes a couple of bugs in NativeWidgetMus 1. Show state was not getting configured correctly. 2. If a ui::WindowObserver was added before NativeWidgetMus, and that ui::WindowObserver queried show state from the widget it could get the wrong results. I'm hoping the change is enough, I may need to introduce a pre-change that NativeWidgetMus uses. We'll see. 3. Changed looking at surface_type to an explicit function is_parallel_widget_in_window_manager(). I added a test for 2, which is the more subtle of the fixes. BUG= 634972 TEST=mostly covered by tests R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2225833003 Cr-Commit-Position: refs/heads/master@{#410460} [modify] https://crrev.com/039443070732a60fbdac74929cfbefc627c565d9/ui/views/mus/native_widget_mus.cc [modify] https://crrev.com/039443070732a60fbdac74929cfbefc627c565d9/ui/views/mus/native_widget_mus.h [modify] https://crrev.com/039443070732a60fbdac74929cfbefc627c565d9/ui/views/mus/native_widget_mus_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cc4373556f64bec8cbe8d3e2ec98c50675459d3 commit 6cc4373556f64bec8cbe8d3e2ec98c50675459d3 Author: sky <sky@chromium.org> Date: Tue Aug 09 14:26:54 2016 Converts mash to use the common non-client frame I left TODOs for figuring out a better way to get insets rather than assuming the code works a particular way. BUG= 634972 TEST=mostly covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2227643003 Cr-Commit-Position: refs/heads/master@{#410661} [modify] https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3/ash/common/frame/custom_frame_view_ash.cc [modify] https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3/ash/common/frame/custom_frame_view_ash.h [modify] https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3/ash/common/frame/header_painter_util.cc [modify] https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3/ash/mus/BUILD.gn [modify] https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3/ash/mus/bridge/wm_window_mus.cc [modify] https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3/ash/mus/bridge/wm_window_mus.h [add] https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3/ash/mus/bridge/wm_window_mus_test_api.h [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/frame/caption_buttons/caption_button_types.h [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/frame/caption_buttons/frame_caption_button.cc [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/frame/caption_buttons/frame_caption_button.h [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/frame/caption_buttons/frame_caption_button_container_view.cc [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/frame/caption_buttons/frame_caption_button_container_view.h [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/frame/default_header_painter.cc [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/frame/default_header_painter.h [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/frame/frame_border_hit_test_controller.cc [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/frame/frame_border_hit_test_controller.h [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/frame/header_painter.h [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/frame/header_painter_util.cc [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/frame/header_painter_util.h [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/frame/non_client_frame_view_mash.cc [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/frame/non_client_frame_view_mash.h [rename] https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3/ash/mus/move_event_handler.cc [rename] https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3/ash/mus/move_event_handler.h [modify] https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3/ash/mus/non_client_frame_controller.cc [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/BUILD.gn [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/ash_mus_resources.grd [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_control_background_hover.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_control_background_pressed.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_control_icon_close.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_control_icon_close_white.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_control_icon_left_snapped.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_control_icon_left_snapped_white.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_control_icon_maximize.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_control_icon_maximize_white.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_control_icon_minimize.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_control_icon_minimize_white.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_control_icon_restore.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_control_icon_restore_white.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_control_icon_right_snapped.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_control_icon_right_snapped_white.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_header_shade_bottom_inactive.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_header_shade_left_inactive.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_header_shade_right_inactive.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_100_percent/common/window_header_shade_top_inactive.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_control_background_hover.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_control_background_pressed.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_control_icon_close.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_control_icon_close_white.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_control_icon_left_snapped.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_control_icon_left_snapped_white.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_control_icon_maximize.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_control_icon_maximize_white.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_control_icon_minimize.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_control_icon_minimize_white.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_control_icon_restore.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_control_icon_restore_white.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_control_icon_right_snapped.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_control_icon_right_snapped_white.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_header_shade_bottom_inactive.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_header_shade_left_inactive.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_header_shade_right_inactive.png [delete] https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd/ash/mus/resources/default_200_percent/common/window_header_shade_top_inactive.png [modify] https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3/ash/mus/window_manager.cc [modify] https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3/ash/mus/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3/mash/example/window_type_launcher/window_type_launcher.cc [modify] https://crrev.com/6cc4373556f64bec8cbe8d3e2ec98c50675459d3/ui/views/mus/native_widget_mus.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf commit 2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf Author: sky <sky@chromium.org> Date: Fri Aug 26 05:27:35 2016 Wires up immersive mode for chrome and mash There is still a slew of things to do, but this is a good start (and rather lengthy). There are two distinct ways for immersive mode to work in mash: 1. Mash takes care of it all. In this mode a separate ui::Window is created for the reveal of the title area. HeaderView is used to render the title area of the reveal in the separate window. The client does nothing special here. 2. The client takes control of it all (as happens in chrome). Chrome too creates a separate window for the reveal. This window is a child of the chrome frame. Mash knows to paint window decorations by way of a special property set on the window. Chrome runs all the immersive logic, including positioning of the reveal window. To get 2 to work I had to relax a constraint of mus, in particular this allows the window manager to set the underlay of any window. Previously only the owner could, but as 2 requires mash to set the underlay I had to relax the constraint. I also changed it so that events in the underlay always go to the window manager, not the owner as previously. BUG= 634972 , 640365 TEST=none R=jamescook@chromium.org, tsepez@chromium.org Review-Url: https://codereview.chromium.org/2277563002 Cr-Commit-Position: refs/heads/master@{#414655} [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/common/frame/custom_frame_view_ash.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/common/frame/custom_frame_view_ash.h [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/common/frame/default_header_painter.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/common/frame/header_view.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/common/frame/header_view.h [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/BUILD.gn [add] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/bridge/immersive_handler_factory_mus.cc [add] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/bridge/immersive_handler_factory_mus.h [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/bridge/wm_shell_mus.h [add] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/frame/README.md [add] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/frame/custom_frame_view_mus.cc [add] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/frame/custom_frame_view_mus.h [add] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/frame/detached_title_area_renderer.cc [add] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/frame/detached_title_area_renderer.h [add] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/frame/detached_title_area_renderer_host.h [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/non_client_frame_controller.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/non_client_frame_controller.h [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/property_util.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/property_util.h [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/mus/root_window_controller.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ash/wm/resize_shadow_and_cursor_unittest.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/chrome/browser/fullscreen_chromeos.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/chrome/browser/ui/views/frame/browser_frame_mus.cc [add] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/chrome/browser/ui/views/frame/immersive_context_mus.cc [add] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/chrome/browser/ui/views/frame/immersive_context_mus.h [add] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/chrome/browser/ui/views/frame/immersive_handler_factory_mus.cc [add] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/chrome/browser/ui/views/frame/immersive_handler_factory_mus.h [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/chrome/browser/ui/views/frame/immersive_mode_controller_factory_views.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/chrome/chrome_browser_ui.gypi [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/services/ui/public/interfaces/window_manager.mojom [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/services/ui/ws/window_finder.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/services/ui/ws/window_manager_access_policy.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/services/ui/ws/window_manager_state.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/services/ui/ws/window_tree.cc [modify] https://crrev.com/2d6a8e0fcb704248b64e7b65f4e76ace658a4bdf/ui/views/mus/native_widget_mus.cc
Comment 1 by sky@chromium.org
, Aug 5 2016