Mac OS, MBP 1. Open DevTools, elements panel 2. Hover over styles sidebar everything flickers regressed in https://crrev.com/ccb9e13712b1632b889960d1d85d556c0139fd51, manual revert helps.
I am preparing a revert due to http://crbug.com/634823 to land today.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/490867260447e9360b52d5c03417b000490332e0 commit 490867260447e9360b52d5c03417b000490332e0 Author: wkorman <wkorman@chromium.org> Date: Fri Aug 05 22:24:57 2016 Revert "Raster display item lists via a visual rect RTree." Meta-revert for http://crrev.com/1484163002 due to bugs found in ui/views and DevTools. Original change description: Raster display item lists via a visual rect RTree. Rather than caching and playing back an entire SkPicture when rastering a display item list for a particular playback rect, instead retain display items and query them via an RTree of their visual rects to find and raster only what's needed. Display item lists no longer support the notion of a bounding "layer rect" with mutable origin. DisplayItemListSettings proto is obsolete after this change as it's comprised solely of one field to allow switching whether to use the aforementioned now-deleted cached SkPicture code path. It will be deleted in a subsequent patch. Revert "Raster display item lists via a visual rect RTree." This reverts commit ccb9e13712b1632b889960d1d85d556c0139fd51. Revert "Don't clear visual rects when finalizing display item lists for now." This reverts commit 1adf72a0a0a3e04151cc740d15ab19655b1e7e5e. Revert "Delete obsolete DisplayItemList::ProcessAppendedItem method definition." This reverts commit f652746f56c59523b0440cf18b769f8ba779d15d. BUG= 529938 , 633750 , 633869 , 634239 , 634823 , 634959 TBR=chrishtr@chromium.org,vmpstr@chromium.org,lushnikov@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2217263003 Cr-Commit-Position: refs/heads/master@{#410190} [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/blink/web_content_layer_impl.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/blink/web_display_item_list_impl.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/debug/rasterize_and_record_benchmark.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/debug/rasterize_and_record_benchmark.h [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/layers/empty_content_layer_client.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/layers/picture_image_layer.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/layers/picture_layer_impl_unittest.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/discardable_image_map_unittest.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/display_item_list.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/display_item_list.h [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/display_item_list_unittest.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/recording_source.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/proto/display_item.proto [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/test/fake_content_layer_client.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/test/skia_common.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/test/solid_color_content_layer_client.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/trees/layer_tree_host_pixeltest_masks.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/trees/layer_tree_host_pixeltest_tiles.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/ui/compositor/canvas_painter.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/ui/compositor/layer.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/ui/views/view_unittest.cc
Reduced testcase attached.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2234389b8ef6a9204d9a37bb17810ab9fdd70441 commit 2234389b8ef6a9204d9a37bb17810ab9fdd70441 Author: chrishtr <chrishtr@chromium.org> Date: Tue Aug 09 16:57:51 2016 Set objects to need full paint invalidation after clearing their invalidation rects. This is necessary in the world of rtrees driven by visual rects, because it's now required that visual rects be correct on every frame. Previously we did not need this to happen, because we just needed to know if an invalidation changed the visual rect. BUG= 634959 Review-Url: https://codereview.chromium.org/2220333004 Cr-Commit-Position: refs/heads/master@{#410712} [modify] https://crrev.com/2234389b8ef6a9204d9a37bb17810ab9fdd70441/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/2234389b8ef6a9204d9a37bb17810ab9fdd70441/third_party/WebKit/LayoutTests/paint/invalidation/update-visual-rects-after-compositing-change-expected.txt [add] https://crrev.com/2234389b8ef6a9204d9a37bb17810ab9fdd70441/third_party/WebKit/LayoutTests/paint/invalidation/update-visual-rects-after-compositing-change.html [modify] https://crrev.com/2234389b8ef6a9204d9a37bb17810ab9fdd70441/third_party/WebKit/Source/core/layout/LayoutObject.cpp [modify] https://crrev.com/2234389b8ef6a9204d9a37bb17810ab9fdd70441/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp [modify] https://crrev.com/2234389b8ef6a9204d9a37bb17810ab9fdd70441/third_party/WebKit/Source/core/testing/Internals.cpp [modify] https://crrev.com/2234389b8ef6a9204d9a37bb17810ab9fdd70441/third_party/WebKit/Source/core/testing/Internals.h [modify] https://crrev.com/2234389b8ef6a9204d9a37bb17810ab9fdd70441/third_party/WebKit/Source/core/testing/Internals.idl
Issue 634823 has been merged into this issue.
Issue 635188 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87 commit fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Tue Aug 09 18:53:29 2016 Auto-rebaseline for r410712 https://chromium.googlesource.com/chromium/src/+/2234389b8 BUG= 634959 TBR=chrishtr@chromium.org Review URL: https://codereview.chromium.org/2232493002 . Cr-Commit-Position: refs/heads/master@{#410759} [modify] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/compositing/will-change/containing-block-added-expected.txt [modify] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/compositing/will-change/containing-block-removed-expected.txt [modify] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/fast/repaint/containing-block-position-change-expected.txt [modify] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/fast/repaint/fixed-and-absolute-position-scrolled-expected.txt [modify] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/fast/repaint/stacking-context-lost-expected.txt [modify] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/containing-block-position-change-expected.txt [add] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/containing-block-position-change-expected.txt [add] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/fixed-and-absolute-position-scrolled-expected.png [add] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/fixed-and-absolute-position-scrolled-expected.txt [add] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/stacking-context-lost-expected.txt [add] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/containing-block-position-change-expected.txt [add] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/fixed-and-absolute-position-scrolled-expected.png [add] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/fixed-and-absolute-position-scrolled-expected.txt [add] https://crrev.com/fe959c33a8a125c5b8f1527fdcc40a7bd4e96b87/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/stacking-context-lost-expected.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/909bb648c96e5275ca8002e2f0aca2b489477b93 commit 909bb648c96e5275ca8002e2f0aca2b489477b93 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Tue Aug 09 20:23:21 2016 Auto-rebaseline for r410759 https://chromium.googlesource.com/chromium/src/+/fe959c33a BUG= 634959 TBR=blink-rebaseline-bot@chromium.org Review URL: https://codereview.chromium.org/2232503003 . Cr-Commit-Position: refs/heads/master@{#410795} [modify] https://crrev.com/909bb648c96e5275ca8002e2f0aca2b489477b93/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/c91b13c8b1e3eb18efc1e9de4ec67fbb2e678e91/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/containing-block-position-change-expected.txt [delete] https://crrev.com/c91b13c8b1e3eb18efc1e9de4ec67fbb2e678e91/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/stacking-context-lost-expected.txt [delete] https://crrev.com/c91b13c8b1e3eb18efc1e9de4ec67fbb2e678e91/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/containing-block-position-change-expected.txt [delete] https://crrev.com/c91b13c8b1e3eb18efc1e9de4ec67fbb2e678e91/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/stacking-context-lost-expected.txt
Comment 1 by wkorman@chromium.org
, Aug 5 2016Components: Blink>Paint