New issue
Advanced search Search tips

Issue 634949 link

Starred by 4 users
Status: Fixed
Owner:
aga...@chromium.org
Closed: Jan 2018
Cc:
tandrii@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Gerrit git cl: remove pointless similarity detection

Project Member Reported by tandrii@chromium.org, Aug 5 2016 
This line is confusing and importantly useless, as this info isn't uploaded to Gerrit anyway.

Using 50% similarity for rename/copy detection. Override with --similarity.

Comment 1 by andyb...@chromium.org, Sep 27 2016

Labels: Milestone-Dogfood

Comment 2 by aga...@chromium.org, Jan 12 2017

Labels: -Milestone-Dogfood Milestone-Afterglow

Comment 3 by isherman@chromium.org, Jul 14 2017 

Can this info please be uploaded to Gerrit, rather than removed?  It is useful to be able to set a custom similarity level, e.g. compare [ https://chromium-review.googlesource.com/c/571438/5 ] to [ https://codereview.chromium.org/2975273003/ ].  I find the latter much easier to review.

Comment 4 by aga...@chromium.org, Jul 17 2017 

See https://bugs.chromium.org/p/gerrit/issues/detail?id=6441 for why it is infeasible to respect --similarity for Gerrit.

Comment 5 by aga...@chromium.org, Jan 3 2018

Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.

Comment 6 by aga...@chromium.org, Jan 5 2018

Owner: aga...@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment