Disable Rietveld usage for infra/infra |
|||||
Issue descriptionCurrently users can still use Rietveld for code reviews even though Gerrit is now the default. This is a tracking bug to disable the use of Rietveld in infra/infra entirely.
,
Nov 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/testing/testing_support/+/3f5ce5775cceffe4fdc078205eefe2bc12f206d4 commit 3f5ce5775cceffe4fdc078205eefe2bc12f206d4 Author: Aaron Gable <agable@chromium.org> Date: Fri Nov 11 22:12:20 2016 Make testing/testing_support upload reviews to Gerrit by default BUG= 634946 Change-Id: I9414fc98b0a9b50bcbed8c28a3854bf349115485 Reviewed-on: https://chromium-review.googlesource.com/410039 Reviewed-by: Andrew Bonventre <andybons@chromium.org> [modify] https://crrev.com/3f5ce5775cceffe4fdc078205eefe2bc12f206d4/codereview.settings
,
Nov 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/testing/expect_tests/+/7b492a7f0b547b2ef8c886c101f27818d7a5c7a6 commit 7b492a7f0b547b2ef8c886c101f27818d7a5c7a6 Author: Aaron Gable <agable@chromium.org> Date: Fri Nov 11 22:12:10 2016 Make testing/expect_tests upload reviews to Gerrit by default BUG= 634946 Change-Id: I6ac59e4e67ba899a1536523460966019342b65f2 Reviewed-on: https://chromium-review.googlesource.com/410143 Reviewed-by: Andrew Bonventre <andybons@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/7b492a7f0b547b2ef8c886c101f27818d7a5c7a6/codereview.settings
,
Nov 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/2bfca886b28b0293e9625f7b339119895870883b commit 2bfca886b28b0293e9625f7b339119895870883b Author: Aaron Gable <agable@chromium.org> Date: Fri Nov 11 22:13:17 2016
,
Nov 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config.git/+/f56f0f46ad24a4e2f5c56775b379d93153671c81 commit f56f0f46ad24a4e2f5c56775b379d93153671c81 Author: Aaron Gable <agable@chromium.org> Date: Fri Nov 11 22:13:31 2016
,
Nov 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/994bde0dac546fe40f9aeebdbf3d0e6a650cc002 commit 994bde0dac546fe40f9aeebdbf3d0e6a650cc002 Author: Aaron Gable <agable@chromium.org> Date: Fri Nov 11 22:15:49 2016
,
Nov 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/site_config/+/abd80014a75cf14be9b161c457a67cc60223637d commit abd80014a75cf14be9b161c457a67cc60223637d Author: Aaron Gable <agable@chromium.org> Date: Fri Nov 11 22:14:44 2016
,
Nov 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/tools/+/ed6f971fc1b620dc8e19fa9f9f93e67f91d9ceee commit ed6f971fc1b620dc8e19fa9f9f93e67f91d9ceee Author: Aaron Gable <agable@chromium.org> Date: Fri Nov 11 22:14:33 2016
,
Nov 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/9b654aa0848af49cc42985476acb58e03f0b72f5 commit 9b654aa0848af49cc42985476acb58e03f0b72f5 Author: Aaron Gable <agable@chromium.org> Date: Fri Nov 11 22:11:56 2016 Make depot_tools upload reviews to Gerrit by default BUG= 634946 Change-Id: I1724395d6ba223854e513543841bdbb317f3ede7 Reviewed-on: https://chromium-review.googlesource.com/410227 Reviewed-by: Andrew Bonventre <andybons@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/9b654aa0848af49cc42985476acb58e03f0b72f5/codereview.settings
,
Nov 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager.git/+/2dbd4613531fbca1a62a9a90e02bb500adc00e7e commit 2dbd4613531fbca1a62a9a90e02bb500adc00e7e Author: Aaron Gable <agable@chromium.org> Date: Fri Nov 11 22:13:42 2016
,
Nov 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager.git/+/2dbd4613531fbca1a62a9a90e02bb500adc00e7e commit 2dbd4613531fbca1a62a9a90e02bb500adc00e7e Author: Aaron Gable <agable@chromium.org> Date: Fri Nov 11 22:13:42 2016
,
Nov 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome-golo/chrome-golo.git/+/aa5c8a263ca43963808c4c4ab9b2ae7e3276b7d6 commit aa5c8a263ca43963808c4c4ab9b2ae7e3276b7d6 Author: Aaron Gable <agable@chromium.org> Date: Fri Nov 11 22:13:53 2016
,
Nov 11 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/55f1fcac08313031334a8844bdd384f600187a28 commit 55f1fcac08313031334a8844bdd384f600187a28 Author: Aaron Gable <agable@chromium.org> Date: Fri Nov 11 22:15:17 2016
,
Nov 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/0b177ff2f11ab2d7f746699b5dc4e9c5aa4b7203 commit 0b177ff2f11ab2d7f746699b5dc4e9c5aa4b7203 Author: Aaron Gable <agable@chromium.org> Date: Fri Nov 11 22:11:22 2016 Make build upload reviews to Gerrit by default BUG= 634946 Change-Id: Ia4cab69d0bef86229b1efcdbc0f3a01dbb777c2e Reviewed-on: https://chromium-review.googlesource.com/410067 Reviewed-by: Andrew Bonventre <andybons@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/0b177ff2f11ab2d7f746699b5dc4e9c5aa4b7203/codereview.settings
,
Nov 28 2016
Out of curiosity, how do we completely disable a repo from uploading to Rietveld?
,
Nov 28 2016
The only sure way is blacklist for project field in Rietveld. But an easy workaround is just prohibiting push to refs/heads/master s.t. Rietveld CLs can't be landed.
,
Jan 13 2017
,
Jan 13 2017
,
May 23 2017
,
Jun 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/23e94e58923e5c2826817245134abc75a39f94d6 commit 23e94e58923e5c2826817245134abc75a39f94d6 Author: Aaron Gable <agable@chromium.org> Date: Wed Jun 28 17:45:15 2017 Rietveld: refuse new uploads in read-only projects This will help enforce that projects which are fully supported on Gerrit don't have any lingering Rietveld usage, and help us burn down the list of repos capable of using Rietveld until none are left. Eventually this will become a whitelist, and then empty. Bug: 600469 , 634946 Change-Id: I472e57d431f54264a5aaf3e0aa09dbec2914f542 Reviewed-on: https://chromium-review.googlesource.com/550776 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/23e94e58923e5c2826817245134abc75a39f94d6/appengine/chromium_rietveld/settings.py [modify] https://crrev.com/23e94e58923e5c2826817245134abc75a39f94d6/appengine/chromium_rietveld/codereview/views.py
,
Jul 25 2017
Whoops, fixed this a month ago. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by andyb...@chromium.org
, Aug 5 2016