New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634945 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit 21 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 535198



Sign in to add a comment

conformance/context/context-attributes-alpha-depth-stencil-antialias.html fails on CMAA

Project Member Reported by robert.b...@intel.com, Aug 5 2016

Issue description

On all platforms that we have enabled CMAA (using shaders in GPU process) the following WebGL conformance test (1.0.4) fails:

conformance/context/context-attributes-alpha-depth-stencil-antialias.html 

with

failed: pixel_1[0] != 255 && pixel_1[0] != 0 || pixel_1[0] == 0 && pixel_2[0] != 255 && pixel_2[0] != 0 should be true. Was false.

 

Comment 1 by kbr@chromium.org, Aug 5 2016

Cc: yunchao...@intel.com qiankun....@intel.com
Components: Blink>WebGL
Labels: GPU-Intel

Comment 2 by kbr@chromium.org, Aug 5 2016

Labels: -OS-Chrome OS-All
Cc: xinghua....@intel.com
As we all know, this case draw a top-left triangle in a square, the size of square is 2*2. 
I had run the case on my chromebook, if I changed the size to 3*3 or 4*4, the case passed. It seemed case only failed when the size is 2*2, and the red channel values of four pixels are 0, 0, 255, 0.
@dongseong Could you help to check whether it is a CMAA regression? thank you.
The CMAA shader implementation in Chromium only processes the color attachments, as documented here: https://www.khronos.org/registry/gles/extensions/INTEL/framebuffer_CMAA.txt
Thus, depth buffers are not processed by CMAA. Maybe this causes the regression?


@belgun, the failure case is sub-case of this html. In this case, it only verifies whether anti-alias feature is valid, and it has disabled the depth, stencil features, etc.
The drawing content is on color attachments, so I think it directly related with CMAA. When creating context, the source code is as below,
if (antialias)
   shouldBeNonNull("gl = getWebGL(2, 2, { depth: false, stencil: false, alpha: false, antialias: true }, [ 0, 0, 0, 1 ], 1, 0)"); 

Comment 7 by yang...@intel.com, Aug 15 2016

I verified the regression came from r403821:"gpu, cmaa: Don't blend isolated L shape because it's not a closed geometry."

Comment 8 by zmo@chromium.org, Aug 15 2016

Labels: -Pri-3 Pri-2
Owner: dongseong.hwang@chromium.org
Status: Assigned (was: Available)
Dongseong, can you take a look?
Owner: dongseon...@intel.com
Thank you for reporting. Let me look immediately.
Hi, IMO, the fixed webgl test is wrong. 

I submitted the WebGL test PR. zmo@, could you review?
https://github.com/KhronosGroup/WebGL/pull/1977

PR #1730 [1] changes the test to pass CMAA wrong behavior.
As the CMAA bug [2] is fixed, this test needs to be more reasonable. See the PR description.
[1] https://github.com/KhronosGroup/WebGL/pull/1730
[2] https://chromium.googlesource.com/chromium/src/+/9df37c48526a8f6b350687e34e75b2eca1961736
Status: Fixed (was: Assigned)
Fixed at the WebGL test. https://github.com/KhronosGroup/WebGL/pull/1977

Sign in to add a comment