Avoid wasting human/bots resources and re-use tryjobs if patchsets differ in base or description only |
||||||||||
Issue descriptionEditing description on Gerrit creates a new patchset. This means all previous tryjobs are discarded. In some way, that's good because description of CL may have directives for CQ processing. On the other hand, for trivial typo fixes, this would be a waste of resources. Hence, either: * document that's the case * teach CQ to figure it out (difficult) Note, that in Rietveld description changes don't result in new patchsets.
,
Aug 13 2016
,
Sep 14 2016
,
Sep 23 2016
,
Sep 27 2016
,
Sep 27 2016
Ravi, why is skia blocked on this bug? Are you lacking capacity?
,
Sep 27 2016
The main resource being wasted here is human patience. Even if we have the bots to re-run the CQ, it adds latency to the critical path of landing the CL, seeing how the broader bot pool handles it, rolling into Chrome, etc.
,
Sep 27 2016
mtklein@ That's true. Thanks for reply!
,
Oct 7 2016
,
Oct 7 2016
,
Nov 16 2016
Friendly ping. This is extremely painful, and I'm finding myself not changing incomplete or incorrect CL titles/descriptions to save the 30+ minutes wait and bot time.
,
Nov 16 2016
I haven't forgotten this, but I have higher priority task to kill gnumbd. The doc is still in RFC state, though I had tentative agreement from Nodir to allow appending tags after job is complete. If someone is willing to work on this, I'll assist gladly, but I won't drive this till I go/git-numberer is done.
,
Nov 29 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/421a572d8a0820a3aa8205e11544204a1159b57f commit 421a572d8a0820a3aa8205e11544204a1159b57f Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Nov 29 18:57:12 2016
,
Nov 29 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/a19d7b0aedd21354e7d003640b7c7d16243f599f commit a19d7b0aedd21354e7d003640b7c7d16243f599f Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Nov 29 22:22:53 2016
,
Nov 29 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/571e27a93780f02a6a4afe41d4cbf84d6b4802f9 commit 571e27a93780f02a6a4afe41d4cbf84d6b4802f9 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Nov 29 22:24:26 2016
,
Nov 29 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/c344aabd866b93c5382c6d721b529cced8867427 commit c344aabd866b93c5382c6d721b529cced8867427 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Nov 29 22:39:07 2016
,
Nov 30 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/bb75b3ad09160727a473e6bb6315567c2c31d259 commit bb75b3ad09160727a473e6bb6315567c2c31d259 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Tue Nov 29 23:00:08 2016
,
Nov 30 2016
Andrii, are you working on this now? Can you please update bug status and ownership respectively if that's the case.
,
Nov 30 2016
Aaron and myself have been working on this, indeed :)
,
Nov 30 2016
So very excited that this is coming soon..
,
Nov 30 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/de3549747eff63774b8754b77246c44a32cf2b84 commit de3549747eff63774b8754b77246c44a32cf2b84 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed Nov 30 16:22:26 2016
,
Nov 30 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/de3549747eff63774b8754b77246c44a32cf2b84 commit de3549747eff63774b8754b77246c44a32cf2b84 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed Nov 30 16:22:26 2016
,
Nov 30 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/100b4ca90ad212ea926ef542893d5c2d961d7a4e commit 100b4ca90ad212ea926ef542893d5c2d961d7a4e Author: Andrii Shyshkalov <tandrii@google.com> Date: Wed Nov 30 18:27:59 2016
,
Nov 30 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/a317a0dcddf4443c84c9ccfa0ef4c919283eddc0 commit a317a0dcddf4443c84c9ccfa0ef4c919283eddc0 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed Nov 30 18:37:28 2016
,
Nov 30 2016
I think I caused this in my prior CL: (from CQ log): [I2016-11-30T13:16:36.830563-08:00 26446 139930603570944 buildbucket_util:509] 15 fetched builds reduced to 30 for GerritPendingCommit(5006, 12)
,
Nov 30 2016
found a bug in counting number of reduced try jobs, fixed in https://chrome-internal-review.googlesource.com/308215.
,
Nov 30 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/3e05dec2585a5f468b4b483e7616caf54d139d85 commit 3e05dec2585a5f468b4b483e7616caf54d139d85 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed Nov 30 22:03:53 2016
,
Dec 1 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/f8753b1ffa44cabd5e3dcc8a609ccbc46e507827 commit f8753b1ffa44cabd5e3dcc8a609ccbc46e507827 Author: Aaron Gable <agable@chromium.org> Date: Wed Nov 30 22:07:58 2016
,
Dec 1 2016
Success on my whitespace CL: https://internal-cq-status.appspot.com/v2/patch-status/chrome-internal-review.googlesource.com/308115/8 the tryjob of PS#7 was re-used https://uberchromegw.corp.google.com/i/internal.infra.try/builders/infra-internal-tester-trusty-64/builds/1310 On the CQ side, I think this is fixed. What remains to be done here is the buildbucket Gerrit plugin side.
,
Dec 3 2016
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/1bc2e45144f2dbda9b4de53c12e74c1d27e5073b commit 1bc2e45144f2dbda9b4de53c12e74c1d27e5073b Author: Aaron Gable <agable@chromium.org> Date: Fri Dec 02 22:27:44 2016 Add docs for testing buildbucket plugin against live data Bug: chromium:634944 Change-Id: If0b841f982588efded1d25048d38ed3930cf5b88 [modify] https://crrev.com/1bc2e45144f2dbda9b4de53c12e74c1d27e5073b/README.md
,
Dec 8 2016
Hey guys, way to go! I think I just experienced the effects of your work on https://skia-review.googlesource.com/c/5657/. The CQ ran bots on PS2, and PS3 (just an edit to the description) didn't re-run them. Thanks so much!
,
Dec 8 2016
Wahoo! This bug should be fully fixed soon. The buildbucket plugin change to display the builds on subsequent patches is landing right now, and then we just have to import and deploy the new version.
,
Dec 12 2016
Issue gerrit:5122 has been merged into this issue.
,
Dec 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/d54c9c4afcdc2243ec8d3ef66111e2976c176d6d commit d54c9c4afcdc2243ec8d3ef66111e2976c176d6d Author: Aaron Gable <agable@chromium.org> Date: Thu Dec 08 01:35:31 2016 Fetch and display buildbucket jobs for prior identical patches The commit queue now reuses buildbucket jobs that were triggered for previous patchsets, if those previous patchsets share the same tree objects (i.e. differ only in commit message). With this change, the buildbucket plugin now crawls the patchset history backwards, finding patchsets with the same diff as the currently-viewed one, and fetches buildbucket buildsets for all of them. BUG= 634944 Change-Id: I46fb95cc5a65eff0243d5711aacd812ffc67dee5 [modify] https://crrev.com/d54c9c4afcdc2243ec8d3ef66111e2976c176d6d/src/main/resources/static/buildbucket.js [modify] https://crrev.com/d54c9c4afcdc2243ec8d3ef66111e2976c176d6d/src/main/resources/static/cr-buildbucket-view.js
,
Jan 3 2017
,
Jan 4 2017
Issue 677171 has been merged into this issue.
,
Jan 4 2017
Issue 678100 has been merged into this issue.
,
Jan 5 2017
This appears to be working in the buildbucket plugin on my whitespace test change: https://chrome-internal-review.googlesource.com/c/308115 The first four patches are the same, and the second four patches are the same, and only show builds appropriate for each. Huzzah!
,
Jan 5 2017
Thanks so much. This has been working really smoothly for me lately. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by tandrii@chromium.org
, Aug 5 2016