New issue
Advanced search Search tips

Issue 634942 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 600469

Blocking:
issue 637561



Sign in to add a comment

make codereview.settings completely unnecessary

Project Member Reported by tandrii@chromium.org, Aug 5 2016

Issue description

Currently with codereview.settings like:

$ git cl upload [--gerrit]
still fails with

Using 50% similarity for rename/copy detection. Override with --similarity.
Command "git config --unset-all rietveld.server" failed.

 
Labels: Proj-Gerrit-Migration
Correction: 
  git cl upload --gerrit
doesn't fail any more.
Blockedon: 600469
This will be fixable once Rietveld is readonly.
Blockedon: -600469
Blocking: 600469
Labels: Milestone-Afterglow
Cc: aga...@chromium.org

Comment 6 by aga...@chromium.org, Dec 14 2016

Summary: make codereview.settings completely unnecessary for gerrit repos (was: make git cl work with minimal or no codereview.settings)
If you're using Gerrit, the only contents necessary are "GERRIT_HOST: True". I'm going to slightly repurpose this bug for getting rid of codereview.settings entirely.

Comment 7 by aga...@chromium.org, Jul 25 2017

Blockedon: 600469
Blocking: -600469
Blocking: 637561
Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
Components: -Infra>Codereview>Gerrit
Labels: -Proj-Gerrit-Migration
Summary: make codereview.settings completely unnecessary (was: make codereview.settings completely unnecessary for gerrit repos)
Project Member

Comment 11 by sheriffbot@chromium.org, Jan 7

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -tandrii@chromium.org
Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)

Sign in to add a comment