New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634938 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Team-Security-UX

Blocking:
issue 604520



Sign in to add a comment

New "info" icon does not appear in the iOS omnibox

Project Member Reported by rohitrao@chromium.org, Aug 5 2016

Issue description

Visit www.cnn.com (or any other HTTP site).

Notice that the old "blank page" icon is shown in the omnibox (when not editing).  Screenshot is attached.

This is broken on both M53 and trunk (M54).  I'm not sure when it regressed.
 
omniboxicon.png
1.5 MB View Download
Blocking: 604520
Thanks for reporting. (@Felt, this is captured in https://docs.google.com/document/d/1r0EEyAid7bAr1PLrFivQE3gCzFTXJH_9OvjjVi0VboE/edit -- seems like a separate issue from the scheme color issues)


Comment 2 by f...@chromium.org, Aug 5 2016

Components: Security>UX
Labels: Hotlist-SecurityIndicators

Comment 3 by cma...@chromium.org, Aug 15 2016

Please do we have any update on this issue?

Comment 4 by f...@chromium.org, Aug 15 2016

pinkerton: palmer@ was working on this but is out. Is there anyone on the iOS team who could help investigate?
Cc: pinkerton@chromium.org
Owner: f...@chromium.org
I spoke with palmer two weeks ago and he nominated some combination of felt@ and emilyschechter@ =)

I don't think we have anyone on the iOS team who can look at this in the M53 timeframe, and it might be a stretch for M54 too.  All of our omnibox OWNERs are pretty swamped getting ready for the next iOS release.

Comment 6 by f...@chromium.org, Aug 15 2016

Cc: -lgar...@chromium.org
Owner: lgar...@chromium.org
Screenshot for https://codereview.chromium.org/2275523003
Screen Shot 2016-08-23 at 23.52.25.png
253 KB View Download
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8f21b33fd602674bf5cddfbe0ef0e5aba7205f9

commit a8f21b33fd602674bf5cddfbe0ef0e5aba7205f9
Author: lgarron <lgarron@chromium.org>
Date: Sat Aug 27 10:51:28 2016

Update iOS neutral omnibox icon from page icon to info icon.

BUG= 634938 

Review-Url: https://codereview.chromium.org/2275523003
Cr-Commit-Position: refs/heads/master@{#414905}

[modify] https://crrev.com/a8f21b33fd602674bf5cddfbe0ef0e5aba7205f9/components/resources/omnibox_scaled_resources.grdp

Labels: -M-53 -ReleaseBlock-Stable M-55 Type-Bug
Status: Fixed (was: Started)
Fixed on Canary.
I was about to ask to merge this, but then I realized that the icon is *meant to afford tapping*, which is not possible on HTTP pages due to  Issue 535357 .

I talked with emilyschechter@ and we agreed that keeping the page icon instead of the info icon on iOS for two more releases is less confusing than merging the changed icon but not having it tappable. I'm going to bump the priority of  Issue 535357 .
IMG_0048.png
177 KB View Download
Components: UI>Browser>Omnibox>SecurityIndicators
Status: Verified (was: Fixed)
Verified on 55.0.2883.55 dev, iPad air 9.3.5, iPad mini4 iOS 10.1
"info" icon appear in the iOS omnibox.
Components: -Security>UX
Labels: -Hotlist-SecurityIndicators

Sign in to add a comment