Issue metadata
Sign in to add a comment
|
New "info" icon does not appear in the iOS omnibox |
||||||||||||||||||||||||
Issue descriptionVisit www.cnn.com (or any other HTTP site). Notice that the old "blank page" icon is shown in the omnibox (when not editing). Screenshot is attached. This is broken on both M53 and trunk (M54). I'm not sure when it regressed.
,
Aug 5 2016
,
Aug 15 2016
Please do we have any update on this issue?
,
Aug 15 2016
pinkerton: palmer@ was working on this but is out. Is there anyone on the iOS team who could help investigate?
,
Aug 15 2016
I spoke with palmer two weeks ago and he nominated some combination of felt@ and emilyschechter@ =) I don't think we have anyone on the iOS team who can look at this in the M53 timeframe, and it might be a stretch for M54 too. All of our omnibox OWNERs are pretty swamped getting ready for the next iOS release.
,
Aug 15 2016
,
Aug 24 2016
Screenshot for https://codereview.chromium.org/2275523003
,
Aug 24 2016
,
Aug 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8f21b33fd602674bf5cddfbe0ef0e5aba7205f9 commit a8f21b33fd602674bf5cddfbe0ef0e5aba7205f9 Author: lgarron <lgarron@chromium.org> Date: Sat Aug 27 10:51:28 2016 Update iOS neutral omnibox icon from page icon to info icon. BUG= 634938 Review-Url: https://codereview.chromium.org/2275523003 Cr-Commit-Position: refs/heads/master@{#414905} [modify] https://crrev.com/a8f21b33fd602674bf5cddfbe0ef0e5aba7205f9/components/resources/omnibox_scaled_resources.grdp
,
Aug 29 2016
Fixed on Canary. I was about to ask to merge this, but then I realized that the icon is *meant to afford tapping*, which is not possible on HTTP pages due to Issue 535357 . I talked with emilyschechter@ and we agreed that keeping the page icon instead of the info icon on iOS for two more releases is less confusing than merging the changed icon but not having it tappable. I'm going to bump the priority of Issue 535357 .
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b23be74cd4ab2d678ddddf7e6d5747012fc2acd commit 3b23be74cd4ab2d678ddddf7e6d5747012fc2acd Author: lgarron <lgarron@chromium.org> Date: Fri Sep 02 04:32:02 2016 Remove unused location_bar_http.png for iOS. BUG= 634938 Review-Url: https://codereview.chromium.org/2268893007 Cr-Commit-Position: refs/heads/master@{#416187} [delete] https://crrev.com/d1258fa441d2b224bb3d70573bfd6c25d9cec62a/components/resources/default_100_percent/omnibox/ios/location_bar_http.png [delete] https://crrev.com/d1258fa441d2b224bb3d70573bfd6c25d9cec62a/components/resources/default_200_percent/omnibox/ios/location_bar_http.png [delete] https://crrev.com/d1258fa441d2b224bb3d70573bfd6c25d9cec62a/components/resources/default_300_percent/omnibox/ios/location_bar_http.png
,
Oct 19 2016
,
Nov 21 2016
Verified on 55.0.2883.55 dev, iPad air 9.3.5, iPad mini4 iOS 10.1 "info" icon appear in the iOS omnibox.
,
Nov 24 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by emilyschechter@chromium.org
, Aug 5 2016