New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634918 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Mac][MaterialDesign] Different space between Omnibox and setting button, when extensions are installed or not

Project Member Reported by meh...@chromium.org, Aug 5 2016

Issue description

Version: Chrome 54.0.2820.0 canary (64-bit)
OS: 10.11.6

What steps will reproduce the problem?
(1) Create a new Chrome profile without any extension installed.
(2) Take a look at the space between Omnibox and Settings button.
(3) Now install an extension and compare the space again.

What is the expected output? What do you see instead?
The space between Omnibox and Setting button is small when no Extension is installed. But it is correct, when an extension is installed.

Please use labels and text to provide additional information.

A screenshot is attached.

Please let me know, if you need more information.

Thanks
Mehmet
 
Bildschirmfoto 2016-08-05 um 16.19.51.png
15.2 KB View Download
Labels: Proj-MaterialDesign-NativeUI
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1b59c4930b456e8bc36574631fba03a77e38a15

commit a1b59c4930b456e8bc36574631fba03a77e38a15
Author: shrike <shrike@chromium.org>
Date: Wed Nov 09 20:03:40 2016

[Mac] Fix tools menu button spacing when no extensions installed.

This cl corrects the spacing between the omnibox and the tools menu
button when there are no extension installed. Before the fix, the
button was 2pt too close to the omnibox.

R=avi@chromium.org
BUG= 634918 

Review-Url: https://codereview.chromium.org/2490833002
Cr-Commit-Position: refs/heads/master@{#431017}

[modify] https://crrev.com/a1b59c4930b456e8bc36574631fba03a77e38a15/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Comment 4 by shrike@chromium.org, Nov 10 2016

Status: Fixed (was: Started)

Comment 5 by shrike@chromium.org, Nov 16 2016

Labels: Proj-NativeMacMD

Sign in to add a comment