New issue
Advanced search Search tips

Issue 634910 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 589598
Owner: ----
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocked on:
issue 589598



Sign in to add a comment

Enable connection migration in cronet tests

Project Member Reported by mge...@chromium.org, Aug 5 2016

Issue description

These tests are currently failing on the L bot:

org.chromium.net.QuicTest#testQuicLoadUrl
org.chromium.net.QuicTest#testQuicLoadUrl_LegacyAPI
org.chromium.net.QuicTest#testRealTimeNetworkQualityObservationsWithQuic

See also  issue 589598  (QUIC connection migration bug, probably the cause of this),  issue 625188  (the same tests failing on N, claims to be fixed)
 
Owner: xunji...@chromium.org
Status: Assigned (was: Available)
Miriam, I can't get this reproduced locally on my M device. Are you able to repro?
Pasting the logs here for easy reference, although it doesn't say why the test fails..

41bd9:  08-05 13:53:25.038 13219 13237 I TestRunner: started: testQuicLoadUrl_LegacyAPI(org.chromium.net.QuicTest)
41bd9:  08-05 13:53:25.059 13219 13239 I cr_QuicTestServer: Quic server started.
41bd9:  08-05 13:53:25.061 13219 13237 I cr_CronetTestFramework: Cronet commandLine libraryInit = legacy
41bd9:  08-05 13:53:25.062 13219 13237 I cr_CronetLibraryLoader: Cronet version: 54.0.2821.0, arch: armv7l
41bd9:  08-05 13:53:25.068 13219 13237 I HttpUrlRequestFactory: Using network stack: Chromium/54.0.2821.0@09deeb01
41bd9:  08-05 13:53:25.072   791   983 D ConnectivityService: listenForNetwork for NetworkRequest [ id=61, legacyType=-1, [ Capabilities: INTERNET&NOT_RESTRICTED&TRUSTED] ]
41bd9:  08-05 13:53:25.090 13219 13240 I TestHttpUrlRequestListener: ****** Request Complete over null, status code is 0
41bd9:  08-05 13:53:25.091 13219 13237 I TestRunner: failed: testQuicLoadUrl_LegacyAPI(org.chromium.net.QuicTest)
41bd9:  08-05 13:53:25.091 13219 13237 I TestRunner: ----- begin exception -----
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: java.lang.Throwable: CronetTestBase#runTest failed.
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:147)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at junit.framework.TestCase.runBare(TestCase.java:134)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at junit.framework.TestResult$1.protect(TestResult.java:115)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at junit.framework.TestResult.runProtected(TestResult.java:133)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at junit.framework.TestResult.run(TestResult.java:118)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at junit.framework.TestCase.run(TestCase.java:124)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: Caused by: junit.framework.AssertionFailedError: expected:<200> but was:<0>
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at junit.framework.Assert.fail(Assert.java:50)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at junit.framework.Assert.failNotEquals(Assert.java:287)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at junit.framework.Assert.assertEquals(Assert.java:67)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at junit.framework.Assert.assertEquals(Assert.java:199)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at junit.framework.Assert.assertEquals(Assert.java:205)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at org.chromium.net.QuicTest.testQuicLoadUrl_LegacyAPI(QuicTest.java:91)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at java.lang.reflect.Method.invoke(Native Method)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at java.lang.reflect.Method.invoke(Method.java:372)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at junit.framework.TestCase.runTest(TestCase.java:168)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:137)
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: 	... 9 more
41bd9:  08-05 13:53:25.092 13219 13237 I TestRunner: ----- end exception -----
41bd9:  08-05 13:53:25.093 13219 13237 I TestRunner: finished: testQuicLoadUrl_LegacyAPI(org.chromium.net.QuicTest)
4

Comment 4 by mef@chromium.org, Aug 5 2016

FWIW I think test devices are not attached to any network. Could this be a difference between local test and bot?
I couldn't reproduce either, but I turned wifi off on my test device and now I can, so looks like that's the issue.
Components: Infra>Client>Android
Owner: bpastene@chromium.org
Great find! Thanks Misha. That is indeed what's missing.
If I turned wifi off, these tests will fail.

bpastene@: should these new bots be attached to a network?
It seems like our tests shouldn't need a network. I don't have a kitkat device to check if the same failures happen, but it's interesting that these are the same tests that were causing a problem in  issue 625188 , so I suspect there's a real bug here.

Comment 8 by mef@chromium.org, Aug 5 2016

I don't think there any networks available in the datacenter, where bots are located.
I think it has something to do with connection migration which is only enabled on L and M. When connection migration is enabled, I think we also query some platform networking APIs. We can disable those on L and M util we figure out why.
Components: -Infra>Client>Android
Owner: ----
Status: Available (was: Assigned)
note that if you switch cronet_test_instrumentation_apk to BaseInstrumentationTestRunner rather than android.test.InstrumentationTestRunner, you should be able to disable those tests on L+ via @DisableIf.Build(sdk_is_greater_than = 20)
Blockedon: 589598
Summary: Enable connection migration in cronet tests (was: Cronet test failures on Android L and M)
I'm disabling connection migration in our tests until this gets fixed.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3faae2e8a5f336edcc8dd09b01655db8fbd0edbc

commit 3faae2e8a5f336edcc8dd09b01655db8fbd0edbc
Author: mgersh <mgersh@chromium.org>
Date: Fri Aug 05 18:24:08 2016

Disable connection migration in cronet tests

It doesn't work on test devices with no network access. Disabling it so
the new bots will turn green.

BUG= 634910 

Review-Url: https://codereview.chromium.org/2224523002
Cr-Commit-Position: refs/heads/master@{#410116}

[modify] https://crrev.com/3faae2e8a5f336edcc8dd09b01655db8fbd0edbc/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Labels: Hotlist-Fixit
Blockedon: -589598
Mergedinto: 589598
Status: Duplicate (was: Available)
I think this is more or less a duplicate of the blocked-on bug.
Blockedon: 589598

Sign in to add a comment