New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634900 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Optimize V8 GC for low memory devices.

Project Member Reported by u...@chromium.org, Aug 5 2016

Issue description

This is the tracking bug for Svelte specific optimizations in V8 garbage collector.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6cebf7d963c18e2ab09f2320c949baf0a4bed721

commit 6cebf7d963c18e2ab09f2320c949baf0a4bed721
Author: ulan <ulan@chromium.org>
Date: Sun Aug 07 15:33:36 2016

Unify memory optimization modes and flags.

This patch folds --optimize-for-size flag and check for low-memory device
into Heap::ShouldOptimizeForMemoryUsage() predicate.

It has the following side effects:
- the heap growing factor for low-memory devices is capped at 1.3 (old value was 2.0).
- the memory reducer will be more aggressive for low-memory devices.

BUG= chromium:634900 

Review-Url: https://codereview.chromium.org/2218703004
Cr-Commit-Position: refs/heads/master@{#38406}

[modify] https://crrev.com/6cebf7d963c18e2ab09f2320c949baf0a4bed721/src/api.cc
[modify] https://crrev.com/6cebf7d963c18e2ab09f2320c949baf0a4bed721/src/heap/heap.cc
[modify] https://crrev.com/6cebf7d963c18e2ab09f2320c949baf0a4bed721/src/heap/heap.h
[modify] https://crrev.com/6cebf7d963c18e2ab09f2320c949baf0a4bed721/src/isolate.cc
[modify] https://crrev.com/6cebf7d963c18e2ab09f2320c949baf0a4bed721/src/isolate.h
[modify] https://crrev.com/6cebf7d963c18e2ab09f2320c949baf0a4bed721/test/cctest/test-api.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8 2016

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a8a7794e49c221f971c3434b9a94a1517ede0e5a

commit a8a7794e49c221f971c3434b9a94a1517ede0e5a
Author: hpayer <hpayer@chromium.org>
Date: Tue Aug 09 07:02:27 2016

[heap] Perform more aggressive compaction when optimizing for memory usage.

BUG= chromium:634900 

Review-Url: https://codereview.chromium.org/2223903002
Cr-Commit-Position: refs/heads/master@{#38471}

[modify] https://crrev.com/a8a7794e49c221f971c3434b9a94a1517ede0e5a/src/heap/mark-compact.cc

Comment 4 Deleted

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a7b7d691064f00feaa37946416e65c76d6b9926e

commit a7b7d691064f00feaa37946416e65c76d6b9926e
Author: hpayer <hpayer@chromium.org>
Date: Tue Aug 09 13:08:57 2016

[heap] Enforce finalization of marking at heap limit when optimizing for memory usage.

BUG= chromium:634900 

Review-Url: https://codereview.chromium.org/2225363002
Cr-Commit-Position: refs/heads/master@{#38495}

[modify] https://crrev.com/a7b7d691064f00feaa37946416e65c76d6b9926e/src/heap/heap-inl.h

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b992a8e1899091e3c180a050c1a63fa1e29886d5

commit b992a8e1899091e3c180a050c1a63fa1e29886d5
Author: hpayer <hpayer@chromium.org>
Date: Fri Aug 12 08:13:35 2016

Fix wrong state of IsolateInBackgroundNotification and IsolateInForegroundNotification.

BUG= chromium:636368 , chromium:635965 , chromium:634900 

Review-Url: https://codereview.chromium.org/2245483004
Cr-Commit-Position: refs/heads/master@{#38598}

[modify] https://crrev.com/b992a8e1899091e3c180a050c1a63fa1e29886d5/src/isolate.cc

Comment 7 by u...@chromium.org, Oct 11 2016

Status: Fixed (was: Assigned)

Sign in to add a comment