ArcBluetoothBridgeTest Failing consistently on Linux Chromium OS ASan LSan Tests (1) |
||
Issue descriptionLinux Chromium OS ASan LSan Tests ( https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1) ) detects leaks in some ArcBluetoothBridgeTest tests, causing it to fail reliably. puthik@ as the author of those tests (from r409945) can you please take a look?
,
Aug 5 2016
I only reverted it as one of today's sheriff so I'm not necessarily the best person to look at this. I started some ASAN trybots on that CL so maybe wait for the results of those and have the CL reviewed by OWNERs. Thanks!
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dea5e4beeecc2dac9ec84dd30741a24d2214795f commit dea5e4beeecc2dac9ec84dd30741a24d2214795f Author: puthik <puthik@chromium.org> Date: Fri Aug 05 21:08:29 2016 arc: bluetooth: Fix LSAN error in fake_bluetooth_instance fake_bluetooth_instance used raw pointer to store all the requests to mojo BluetoothInstance. However, this can easisly caused memory leak unless we are carefully delete those data. This CL changes it to std::unique_ptr<> to auto destroy those data when fake_bluetooth_instance is destroyed. BUG= 634898 TEST=Run tests with ASAN and LSAN Review-Url: https://codereview.chromium.org/2214263006 Cr-Commit-Position: refs/heads/master@{#410160} [modify] https://crrev.com/dea5e4beeecc2dac9ec84dd30741a24d2214795f/components/arc/test/fake_bluetooth_instance.cc [modify] https://crrev.com/dea5e4beeecc2dac9ec84dd30741a24d2214795f/components/arc/test/fake_bluetooth_instance.h
,
Aug 6 2016
The link in #0 shows 2 consecutive green build. |
||
►
Sign in to add a comment |
||
Comment 1 by puthik@chromium.org
, Aug 5 2016