Issue metadata
Sign in to add a comment
|
Integer-overflow in cc::PictureLayerImpl::AppendQuads |
||||||||||||||||||||
Issue descriptionDetailed report: https://cluster-fuzz.appspot.com/testcase?key=5840571006713856 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: cc::PictureLayerImpl::AppendQuads cc::LayerTreeHostImpl::CalculateRenderPasses cc::LayerTreeHostImpl::PrepareToDraw Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=407167:409223 Minimized Testcase (0.32 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96KhPBJzGktOjgVocp6oD7ODA0LcYtFXJ30SGp14HprIy9hBvCespiQ35okrKWIiY5rHH2GAdzz0zY2ynerYUnZbWsDRfHuDRsHaJbnH_GKG0TFDRfpsY7jKfgZCauuy1RIFFtLmZfSu3MoKMptb2BEkaIamQ?testcase_id=5840571006713856 Issue manually filed by: ranjitkan See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Aug 5 2016
--> danakj@ Maybe the code should use visible_geometry_rect.size.GetArea() (which I think in this case would CHECK instead)?
,
Aug 6 2016
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1127cbf181298f0eadfe8d7582a6b0a97c6922a8 commit 1127cbf181298f0eadfe8d7582a6b0a97c6922a8 Author: vmpstr <vmpstr@chromium.org> Date: Thu Aug 11 23:58:49 2016 cc: Remove area calculation overflow in PictureLayerImpl::AppendQuads. This patch ensures that we don't overflow integer bounds when calculating area for various reporting. Note that the types in which the value is stored is already int64_t; it's just a matter of ensuring the temporary calculation on the rhs also uses 64 bit ints. R=danakj, enne BUG= 634824 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2239883002 Cr-Commit-Position: refs/heads/master@{#411457} [modify] https://crrev.com/1127cbf181298f0eadfe8d7582a6b0a97c6922a8/cc/layers/picture_layer_impl.cc
,
Aug 12 2016
,
Aug 13 2016
ClusterFuzz has detected this issue as fixed in range 411432:411522. Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5840571006713856 Fuzzer: inferno_twister Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: cc::PictureLayerImpl::AppendQuads cc::LayerTreeHostImpl::CalculateRenderPasses cc::LayerTreeHostImpl::PrepareToDraw Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=407167:409223 Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=411432:411522 Minimized Testcase (0.32 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96KhPBJzGktOjgVocp6oD7ODA0LcYtFXJ30SGp14HprIy9hBvCespiQ35okrKWIiY5rHH2GAdzz0zY2ynerYUnZbWsDRfHuDRsHaJbnH_GKG0TFDRfpsY7jKfgZCauuy1RIFFtLmZfSu3MoKMptb2BEkaIamQ?testcase_id=5840571006713856 See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Nov 22 2016
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Aug 5 2016Components: Tools>Test>FindIt>CorrectResult
Labels: -Pri-1 -Type-Bug M-54 Findit-for-crash Te-Logged Pri-2 Type-Bug-Regression
Owner: sadrul@chromium.org
Status: Assigned (was: Untriaged)