Issue metadata
Sign in to add a comment
|
Source panel text vanished when highlighted
Reported by
remysh...@gmail.com,
Aug 5 2016
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2820.0 Safari/537.36 Steps to reproduce the problem: 1. Open devtools and select source panel 2. Select some text 3. Text vanishes What is the expected behavior? Text shouldn't vanish. Also seeing this in the element's styles panel What went wrong? Blocks of text vanish. Did this work before? N/A Chrome version: 54.0.2820.0 Channel: canary OS Version: OS X 10.10.3 Flash Version: Shockwave Flash 22.0 r0 Started happening in the previous version of canary (to this one).
,
Aug 5 2016
Easily reproducible on Mac. Bisected down to the following range: https://chromium.googlesource.com/chromium/src/+log/cae1058e62b7960796709512c4e1e650b6389c0f..994c65ef57ec7c84b18fd66d7b8b85e5a2dc29bd Reverting crrev.com/ccb9e13712b1632b889960d1d85d556c0139fd51 (with two another patches atop) mitigated the issue.
,
Aug 5 2016
This issue combined with several others I am looking at http://crbug.com/634239 http://crbug.com/633869 http://crbug.com/633750 is sufficient to warrant reverting my change as time to fix is not clear. I will prepare revert patch.
,
Aug 5 2016
,
Aug 5 2016
,
Aug 5 2016
I can reproduce on linux with --enable-prefer-compositing-to-lcd-text Still repros even if I revert the culling in rtree.cc and drawing_display_item.cc.
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/490867260447e9360b52d5c03417b000490332e0 commit 490867260447e9360b52d5c03417b000490332e0 Author: wkorman <wkorman@chromium.org> Date: Fri Aug 05 22:24:57 2016 Revert "Raster display item lists via a visual rect RTree." Meta-revert for http://crrev.com/1484163002 due to bugs found in ui/views and DevTools. Original change description: Raster display item lists via a visual rect RTree. Rather than caching and playing back an entire SkPicture when rastering a display item list for a particular playback rect, instead retain display items and query them via an RTree of their visual rects to find and raster only what's needed. Display item lists no longer support the notion of a bounding "layer rect" with mutable origin. DisplayItemListSettings proto is obsolete after this change as it's comprised solely of one field to allow switching whether to use the aforementioned now-deleted cached SkPicture code path. It will be deleted in a subsequent patch. Revert "Raster display item lists via a visual rect RTree." This reverts commit ccb9e13712b1632b889960d1d85d556c0139fd51. Revert "Don't clear visual rects when finalizing display item lists for now." This reverts commit 1adf72a0a0a3e04151cc740d15ab19655b1e7e5e. Revert "Delete obsolete DisplayItemList::ProcessAppendedItem method definition." This reverts commit f652746f56c59523b0440cf18b769f8ba779d15d. BUG= 529938 , 633750 , 633869 , 634239 , 634823 , 634959 TBR=chrishtr@chromium.org,vmpstr@chromium.org,lushnikov@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2217263003 Cr-Commit-Position: refs/heads/master@{#410190} [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/blink/web_content_layer_impl.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/blink/web_display_item_list_impl.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/debug/rasterize_and_record_benchmark.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/debug/rasterize_and_record_benchmark.h [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/layers/empty_content_layer_client.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/layers/picture_image_layer.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/layers/picture_layer_impl_unittest.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/discardable_image_map_unittest.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/display_item_list.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/display_item_list.h [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/display_item_list_unittest.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/playback/recording_source.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/proto/display_item.proto [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/test/fake_content_layer_client.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/test/skia_common.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/test/solid_color_content_layer_client.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/trees/layer_tree_host_pixeltest_masks.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/cc/trees/layer_tree_host_pixeltest_tiles.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/ui/compositor/canvas_painter.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/ui/compositor/layer.cc [modify] https://crrev.com/490867260447e9360b52d5c03417b000490332e0/ui/views/view_unittest.cc
,
Aug 9 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by eostroukhov@chromium.org
, Aug 5 2016Status: Assigned (was: Unconfirmed)