New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 634819 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in blink::FrameView::incrementVisuallyNonEmptyPixelCount

Project Member Reported by ClusterFuzz, Aug 5 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6751769759842304

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::FrameView::incrementVisuallyNonEmptyPixelCount
  blink::LayoutImage::imageChanged
  blink::ImageResource::addObserver
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=370022:370027

Minimized Testcase (0.35 Kb): https://cluster-fuzz.appspot.com/download/AMIfv940VpYiSB60jxIGKfzRQwJWOnG-Z4tBP5W9q1EeIVSs_BKMPQmsNToBIwHyOSJmLgapUSWLQ1D2mLcxqOgrXmBC6SaACZPbambllOjFYpIrOyeF4UmBBSW32IGOqKFQzzPYHIs5hPyHYvDfe4bTRIjrVpGSIg?testcase_id=6751769759842304

Issue manually filed by: ranjitkan

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: ranjitkan@chromium.org
Components: Tools>Test>FindIt>CorrectResult
Labels: -Pri-1 -Type-Bug M-54 Findit-for-crash Te-Logged Pri-2 Type-Bug-Regression
Owner: hirosh...@chromium.org
Status: Assigned (was: Untriaged)
Author: hiroshige
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/a4581858f57e20724f9b8a3166ef9c864f79a758
Time: Sat Mar 26 00:50:09 2016
The CL last changed line 74 of file LayoutImageResource.cpp, which is stack frame 3.

@hiroshige: Assigning to you, request you to please take a look into it. Please help us to reassign if not with respect to your change.

Thanks.!
This looks like when opening an SVG of size 59432 * 66035, the area overflows.
Labels: -Type-Bug-Regression Type-Bug
This seems to exist since very long ago.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18614431f3b09bf247aaaece45839a1739affc01

commit 18614431f3b09bf247aaaece45839a1739affc01
Author: hiroshige <hiroshige@chromium.org>
Date: Mon Aug 08 16:36:48 2016

Fix integer overflow in FrameView::m_visuallyNonEmptyPixelCount

BUG= 634819 

Review-Url: https://codereview.chromium.org/2218003003
Cr-Commit-Position: refs/heads/master@{#410380}

[modify] https://crrev.com/18614431f3b09bf247aaaece45839a1739affc01/third_party/WebKit/Source/core/frame/FrameView.h

Project Member

Comment 5 by ClusterFuzz, Aug 9 2016

ClusterFuzz has detected this issue as fixed in range 410349:410400.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6751769759842304

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::FrameView::incrementVisuallyNonEmptyPixelCount
  blink::LayoutImage::imageChanged
  blink::ImageResource::addObserver
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=370022:370027
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=410349:410400

Minimized Testcase (0.35 Kb): https://cluster-fuzz.appspot.com/download/AMIfv940VpYiSB60jxIGKfzRQwJWOnG-Z4tBP5W9q1EeIVSs_BKMPQmsNToBIwHyOSJmLgapUSWLQ1D2mLcxqOgrXmBC6SaACZPbambllOjFYpIrOyeF4UmBBSW32IGOqKFQzzPYHIs5hPyHYvDfe4bTRIjrVpGSIg?testcase_id=6751769759842304

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Aug 9 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/924bbbbfed37fa4c08187bdc137aeed76e8b96ec

commit 924bbbbfed37fa4c08187bdc137aeed76e8b96ec
Author: hiroshige <hiroshige@chromium.org>
Date: Fri Sep 30 06:10:07 2016

Test that FrameView::incrementVisuallyNonEmptyPixelCount() doesn't overflow

This CL adds an unit test for https://codereview.chromium.org/2218003003/ that
would have failed before that CL.

BUG= 634819 

Review-Url: https://codereview.chromium.org/2229753002
Cr-Commit-Position: refs/heads/master@{#422040}

[modify] https://crrev.com/924bbbbfed37fa4c08187bdc137aeed76e8b96ec/third_party/WebKit/Source/core/frame/FrameViewTest.cpp
[modify] https://crrev.com/924bbbbfed37fa4c08187bdc137aeed76e8b96ec/third_party/WebKit/Source/web/tests/WebMeaningfulLayoutsTest.cpp

Project Member

Comment 8 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment