Regression : Search box is seen misplaced and Separator line is half chopped in chrome://bookmarks.
Reported by
yfulgaon...@etouch.net,
Aug 5 2016
|
|||||||||||||
Issue descriptionChrome Version: 54.0.2820.0 (Official Build) 41f9e395f017af1d8c3c2b51f13e404445ba5f07-refs/heads/master@{#409955} (64-bit) OS: Mac (10.10.5, 10.11.5), Windows (7,8,10) What steps will reproduce the problem? 1. Launch chrome and go to chrome://bookmarks. 2. Observe the Search Box and Separator line. Actual : Search box is seen misplaced and Separator line is seen half chopped. Expected : No such misplacement should be seen in bookmarks manager. This is a regression issue broken in M-54, below is Manual Regression info and will soon update other info. Manual Regression : Good build: 54.0.2817.0 Bad build: 54.0.2819.0
,
Aug 5 2016
Narrow Bisect : https://chromium.googlesource.com/chromium/src/+log/67b240c6628573aa3437e14fc82edcb7de78e944..8dfa12f1b8845bc912728471d19d9915119456d7?pretty=fuller&n=10000 Suspecting: r409495 ? from narrow bisect @rune : Please help to re-assign if your change is not the cause for this issue. Note : Issue is also seen on Linux (14.04 LTS) OS.
,
Aug 5 2016
Reverting these did not fix the issue: 8dfa12f 473ac08 6472bb8 This didn't revert cleanly, so I didn't check it: 6526c5b Are you sure the regression range is correct?
,
Aug 5 2016
With response to comment #3 Re-bisected on different machine and got the same narrow bisect range. @haraken : Could you please take a look
,
Aug 5 2016
Hmm, the only suspicious change in the range is rr409495. rune@: Are you sure that your CL is not related?
,
Aug 5 2016
It's 8dfa12f1b. I don't know why the revert didn't make it work again, but checking out and building that commit shows the bug. The commit for haraken's change works.
,
Aug 12 2016
Issue 637208 has been merged into this issue.
,
Aug 12 2016
Issue 551238 has been merged into this issue.
,
Aug 14 2016
html_inline.py ignores <include> directive in external stylesheets. It replaces src with base64 value in externals but when src attr belongs to include directive, final output has include directive and that breaks the page.
,
Aug 18 2016
Somebody else is going to have to look at this. I am on vacation for the next two weeks. Removing myself as owner.
,
Sep 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0f1f24c00093e0112f7c7956fb07518fc49aa29 commit f0f1f24c00093e0112f7c7956fb07518fc49aa29 Author: ahmetemiremir <ahmetemiremir@gmail.com> Date: Sun Sep 04 09:24:36 2016 html_inline.py ignores <include> directive in external stylesheets. It replaces src with base64 value in externals but when when src attr belongs to include directive, final output has include directive.This commit recheck inline css that can have include directive. BUG= 634704 Review-Url: https://codereview.chromium.org/2249493002 Cr-Commit-Position: refs/heads/master@{#416470} [modify] https://crrev.com/f0f1f24c00093e0112f7c7956fb07518fc49aa29/tools/grit/grit/format/html_inline.py [modify] https://crrev.com/f0f1f24c00093e0112f7c7956fb07518fc49aa29/tools/grit/grit/format/html_inline_unittest.py
,
Sep 5 2016
,
Sep 15 2016
Should this be merged to 54?
,
Sep 21 2016
Issue 645751 has been merged into this issue.
,
Sep 28 2016
ahmetemiremir@: Could you please get the CL merged to M-54 as well. Assigning to flackr@ as the reviewer of the CL for help in merging this to M-54. Note: Issue works fine on the latest canary(55.0.2873.3) on Windows 10, Mac OS 10.11.6 and Linux Ubuntu 14.04. Hence adding the verified label.
,
Sep 29 2016
Issue 649488 has been merged into this issue.
,
Sep 29 2016
,
Sep 29 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/420a1094ce45529b450532eaf916f6a33e595eae commit 420a1094ce45529b450532eaf916f6a33e595eae Author: Robert Flack <flackr@chromium.org> Date: Thu Sep 29 14:34:35 2016 html_inline.py ignores <include> directive in external stylesheets. It replaces src with base64 value in externals but when when src attr belongs to include directive, final output has include directive.This commit recheck inline css that can have include directive. BUG= 634704 Review-Url: https://codereview.chromium.org/2249493002 Cr-Commit-Position: refs/heads/master@{#416470} (cherry picked from commit f0f1f24c00093e0112f7c7956fb07518fc49aa29) Review URL: https://codereview.chromium.org/2378923003 . Cr-Commit-Position: refs/branch-heads/2840@{#578} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/420a1094ce45529b450532eaf916f6a33e595eae/tools/grit/grit/format/html_inline.py [modify] https://crrev.com/420a1094ce45529b450532eaf916f6a33e595eae/tools/grit/grit/format/html_inline_unittest.py
,
Sep 29 2016
,
Oct 5 2016
Tested the issue on Chrome Beta# 54.0.2840.50 on Windows, Mac and Linux and is working without any rendering issue. Hence adding TE-Verified Labels. Attaching screenshot for reference. Thank You.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/420a1094ce45529b450532eaf916f6a33e595eae commit 420a1094ce45529b450532eaf916f6a33e595eae Author: Robert Flack <flackr@chromium.org> Date: Thu Sep 29 14:34:35 2016 html_inline.py ignores <include> directive in external stylesheets. It replaces src with base64 value in externals but when when src attr belongs to include directive, final output has include directive.This commit recheck inline css that can have include directive. BUG= 634704 Review-Url: https://codereview.chromium.org/2249493002 Cr-Commit-Position: refs/heads/master@{#416470} (cherry picked from commit f0f1f24c00093e0112f7c7956fb07518fc49aa29) Review URL: https://codereview.chromium.org/2378923003 . Cr-Commit-Position: refs/branch-heads/2840@{#578} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/420a1094ce45529b450532eaf916f6a33e595eae/tools/grit/grit/format/html_inline.py [modify] https://crrev.com/420a1094ce45529b450532eaf916f6a33e595eae/tools/grit/grit/format/html_inline_unittest.py |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by arimin...@gmail.com
, Aug 5 2016