New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 634678 link

Starred by 2 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Oct 2016
Cc:
nyerramilli@chromium.org
bettes@chromium.org
█ ranjitkan@chromium.org
hcarmona@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Autofill] Unnecessary width of drop down list is increased under 'Expiration date' .

Reported by rk...@etouch.net, Aug 5 2016 
Chrome Version: 54.0.2819.0 Revision 0f4bd62f11a1b6eb19feed0e034881b9af953ed7-refs/heads/master@{#409769} 
OS: Windows(7,8,10) Mac(10.10.5, 10.11.4)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://md-settings/autofill
(2) Click on 'Add credit card' link then click on Drop down under 'Expiration date' and observe

Actual: Unnecessary width of drop down list is increased under 'Expiration date'  

Expected: Width of drop down list should be proper under 'Expiration date'  

This is a regression issue, broken in M-54 series,will soon update the other info:

Comment 1 by rk...@etouch.net, Aug 5 2016

Labels: hasbisect OS-Linux OS-Mac
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Good Build: 54.0.2817.0
Bad Build: 54.0.2819.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/05639ea3eebccf27d97bc031755d52f7a9feaaac..09cfb18fdabab040b47b637331ed5e2bd4d8a7ad?pretty=fuller&n=100

Suspecting: r409431

Comment 2 by dschuyler@chromium.org, Aug 8 2016 

Here's what they look like with the larger widths.
Screenshot from 2016-08-08 11:55:11.png
16.3 KB View Download
Screenshot from 2016-08-08 11:56:10.png
18.2 KB View Download

Comment 3 by dschuyler@chromium.org, Aug 8 2016

Cc: hcarmona@chromium.org
Owner: bettes@chromium.org
Alan, How would you like these sized?
The screen shots show them with the values from the spec at
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_menu.png%3Fz=width

But maybe these should be exceptions, WDYT?

+CC hcarmona

Comment 4 by tbuck...@chromium.org, Aug 10 2016

Labels: Hotlist-MD-Settings-General

Comment 5 by bettes@chromium.org, Aug 11 2016 

Per our UX meeting last week, we determined that the correct width on select-like things (such as in comment 2) should be the width of the component associated with it.

For other menus (like the 3-dot overflow): 
Min-width: 128px
Max-height: 320px

Specific to this example, the month menu should be popping down and not up.
Untitled.mov.gif
439 KB View Download

Comment 6 by tbuck...@chromium.org, Aug 15 2016

Cc: bettes@chromium.org
Owner: hcarmona@chromium.org
From bettes@ in our UX sync:
* Min-width on menus: 128px
* Max-height: 320px
* For dropdown-like things, we should try to use the same width as the component associated with it (i.e. menu should be same width as the dropdown).

Comment 7 by dpa...@chromium.org, Oct 5 2016

Owner: dpa...@chromium.org
Status: Fixed (was: Assigned)
Fixed as of https://codereview.chromium.org/2383513003 (see attachment).
expiration_date_width.png
17.4 KB View Download
►

Sign in to add a comment