Regression: Cursor is not seen in search field on back navigation even if focus is there.
Reported by
rk...@etouch.net,
Aug 5 2016
|
||||||
Issue descriptionChrome Version: 54.0.2819.0 Revision 0f4bd62f11a1b6eb19feed0e034881b9af953ed7-refs/heads/master@{#409769} OS: Windows(7,8,10) Mac(10.10.5, 10.11.4) What steps will reproduce the problem? 1. Launch chrome,navigate to chrome://history page. 2. Click on 'Action' icon of any URL and select 'More from this site' option. 3. Select the checkbox of any URL and click on 'DELETE' button on toolbar. 4. Now, press back navigation button and observe. Actual: Cursor is not seen in search field even if focus is there after clicking on back navigation button. Expected: Cursor should seen in search field. This is a regression issue, broken in M-54 series,will soon update the other info:
,
Aug 5 2016
Adding release block label, please undo if not the case.
,
Aug 9 2016
,
Aug 9 2016
This is an edge-case focus issue, bumping down to P3.
,
Nov 18 2016
This is actually a similar issue to issue 665307 . The idea I came up with for it should work here too.
,
Jan 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda commit d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda Author: tsergeant <tsergeant@chromium.org> Date: Thu Jan 19 01:00:44 2017 MD Settings: Fix label visibility in subpage search fields In crrev.com/438430, CrSearchFieldBehavior was simplified, removing compatibility with iron-input. However, iron-input was still used by <settings-subpage-search> to control the visibility of the input field label. This CL adds a public 'hasSearchText' property to the common search field behavior which does not require iron-input to compute. This allows <settings-subpage-search> to remove its dependency on iron-input, while also fixing two minor issues: - The input field label on <settings-subpage-search> now reappears when the 'clear search' button is clicked. - The search icon in <cr-toolbar-search-field> now appears unfocused when the search field is cleared while it is unfocused. BUG= 665700 , 665307 , 634665 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2586803002 Cr-Commit-Position: refs/heads/master@{#444578} [modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/chrome/browser/resources/md_downloads/vulcanized.html [modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/chrome/browser/resources/md_history/app.vulcanized.html [modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/chrome/browser/resources/settings/settings_page/settings_subpage_search.html [modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js [modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js [modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html [modify] https://crrev.com/d69fa965ea7ddc2e61c7701a6b209c1d5f8bccda/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js
,
Jan 19 2017
This is now fixed. When clicking back, the search field will clear and completely unfocus, which is the intended behavior. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rk...@etouch.net
, Aug 5 2016Owner: calamity@chromium.org
Status: Assigned (was: Unconfirmed)
435 KB
435 KB View Download